Skip to content

fix(api-axios): override getUrl in AvStashApi to support get by id #990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordan-a-young merged 2 commits into from
May 28, 2026
Merged

fix(api-axios): override getUrl in AvStashApi to support get by id #990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fcc0848
fix(api-axios): override getUrl in AvStashApi to support get by id
btrinhav May 27, 2026
054ca3f
fix(api-axios): use path/name config in AvStashApi to support get by id
btrinhav May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/api-axios/src/resources/stash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ import AvApi from '../api';
export default class AvStashApi extends AvApi {
constructor(config) {
super({
url: '/cloud/web/appl/stash/v1/session/data',
api: false,
path: 'cloud/web/appl/stash',
name: 'session/data',
...config,
});
}
Expand Down
4 changes: 4 additions & 0 deletions packages/api-axios/src/resources/tests/stash.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ describe('AvStashApi', () => {
expect(api.getUrl(api.config())).toBe('/cloud/web/appl/stash/v1/session/data');
});

test('url should include id when provided', () => {
expect(api.getUrl(api.config(), 'abc-123')).toBe('/cloud/web/appl/stash/v1/session/data/abc-123');
});

test('launch throws when linkTo is not provided', async () => {
await expect(() => api.launch({ key: 'value' })).rejects.toThrow(
'linkTo is required and was not provided'
Expand Down
Loading