Skip to content

Fixing test failures in test_ecn_config_update.py #1188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mramezani95 merged 2 commits into from
May 19, 2026
+3 −9
Merged

Fixing test failures in test_ecn_config_update.py #1188

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11f017d
Unchanged WRED profiles are now added to 'new_values' for comparison …
mramezani95 May 12, 2026
cde0e43
Removed a redundant try-finally block.
mramezani95 May 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions tests/generic_config_updater/test_ecn_config_update.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,9 +227,6 @@ def test_ecn_config_updates(duthost, ensure_dut_readiness, configdb_field, opera
if not wred_green_enabled:
logger.info(f"Not modifying the WRED profile {wred_profile} since 'wred_green_enable' is false.")
delta = determine_delta_values(ecn_data, fields, wred_green_enabled)
if all(delta[f] == 0 for f in fields):
logger.info(f"Skipping WRED profile {wred_profile}: all deltas are 0, no real value change possible.")
continue
new_values[wred_profile] = {}
for field in fields:
value = int(ecn_data[field])
Expand All @@ -247,9 +244,6 @@ def test_ecn_config_updates(duthost, ensure_dut_readiness, configdb_field, opera
pytest.skip("All WRED profiles have zero deltas for the requested fields, skipping test.")

json_patch = format_json_patch_for_multiasic(duthost=duthost, json_data=json_patch, is_asic_specific=True)
try:
output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile)
expect_op_success(duthost, output)
ensure_application_of_updated_config(duthost, fields, new_values)
finally:
delete_tmpfile(duthost, tmpfile)
output = apply_patch(duthost, json_data=json_patch, dest_file=tmpfile)
expect_op_success(duthost, output)
ensure_application_of_updated_config(duthost, fields, new_values)
Loading