Fixing test failures in test_ecn_config_update.py#1188
Merged
mramezani95 merged 2 commits intoMay 19, 2026
Merged
Conversation
…with ASIC DB profiles. Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
May 12, 2026
12 tasks
Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mramezani95
added a commit
to sonic-net/sonic-mgmt
that referenced
this pull request
May 12, 2026
<!-- Please make sure you've read and understood our contributing guidelines; https://github.com/sonic-net/SONiC/blob/gh-pages/CONTRIBUTING.md Please provide following information to help code review process a bit easier: --> ### Description of PR <!-- - Please include a summary of the change and which issue is fixed. - Please also include relevant motivation and context. Where should reviewer start? background context? - List any dependencies that are required for this change. --> This PR ports the following two PRs from 202412 to master: Azure/sonic-mgmt.msft#1024 Azure/sonic-mgmt.msft#1188 Summary: Skip updating WRED profiles for which `wred_green_enabled` is false. ### Type of change <!-- - Fill x for your type of change. - e.g. - [x] Bug fix --> - [ ] Bug fix - [ ] Testbed and Framework(new/improvement) - [ ] New Test case - [ ] Skipped for non-supported platforms - [x] Test case improvement ### Back port request - [ ] 202205 - [ ] 202305 - [ ] 202311 - [ ] 202405 - [ ] 202411 - [ ] 202505 - [x] 202511 ### Approach #### What is the motivation for this PR? Ensuring that tests don't fail when for some WRED profiles, `wred_green_enabled=false`. #### How did you do it? We set all delta values to 0 if `wred_green_enabled=false` for a WRED profile and do not create a JSON patch for that profile. #### How did you verify/test it? Ran the tests: ``` generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_min_threshold] PASSED [ 25%] generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_max_threshold] PASSED [ 50%] generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_drop_probability] PASSED [ 75%] generic_config_updater/test_ecn_config_update.py::test_ecn_config_updates[None-replace-green_min_threshold,green_max_threshold,green_drop_probability] PASSED [100%] ``` #### Any platform specific information? N/A #### Supported testbed topology if it's a new test case? N/A ### Documentation <!-- (If it's a new feature, new test case) Did you update documentation/Wiki relevant to your implementation? Link to the wiki page? --> N/A Signed-off-by: Mahdi Ramezani <mramezani@microsoft.com>
Author
|
Merging this PR since test failures are unrelated to the changes ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the motivation for this PR?
Fixing test failures in
test_ecn_config_update.py.How did you do it?
WRED profiles that are not changed by the test (e.g., because
wred_green_enableis false for them) still appear in ASIC DB. So we should add these profiles to thenew_valuesdictionary. I removed thecontinuestatement so that these profiles are added tonew_valuesfor comparison with ASIC DB profiles.How did you verify/test it?
Ran the tests on a Broadcom TH5 switch: