test: handle file URL paths with spaces#57
Open
TateLyman wants to merge 1 commit into
Open
Conversation
02f5019 to
3abce0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fileURLToPath(...)so spawnednode dist/index.jscalls work when the checkout path contains spaces.VERSIONfile to the currentpackage.jsonversion,3.18.0.Why
Running
npm testfrom a checkout path such asNew project 7failed becauseURL.pathnameproducedNew%20project%207, so Node tried to execute a non-existent encoded path.fileURLToPathpreserves the real filesystem path.Validation
npm run buildnpm testbefore rebase: 391/391 passingmain/3.18.0;npm testreached 392/393 passing, with one unrelated task-wait timeoutnode --test --test-reporter=spec --test-name-pattern "cli: franklin task wait reconciles stale queued tasks before blocking" test/local.mjs-> passinggit diff --check