Skip to content

test: handle file URL paths with spaces #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1bcMax merged 1 commit into from
May 16, 2026
Merged

test: handle file URL paths with spaces #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.9.4
3.18.0
3 changes: 2 additions & 1 deletion test/e2e.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ import { spawn } from 'node:child_process';
import { mkdirSync, writeFileSync, readFileSync, existsSync, rmSync } from 'node:fs';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import { fileURLToPath } from 'node:url';

const DIST = new URL('../dist/index.js', import.meta.url).pathname;
const DIST = fileURLToPath(new URL('../dist/index.js', import.meta.url));
const TIMEOUT_MS = 90_000; // 90s per test — model calls can be slow

// ─── Helper ────────────────────────────────────────────────────────────────
Expand Down
3 changes: 2 additions & 1 deletion test/free-model-matrix.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,9 @@ import { test } from 'node:test';
import assert from 'node:assert/strict';
import { spawn } from 'node:child_process';
import { tmpdir } from 'node:os';
import { fileURLToPath } from 'node:url';

const DIST = new URL('../dist/index.js', import.meta.url).pathname;
const DIST = fileURLToPath(new URL('../dist/index.js', import.meta.url));
const TIMEOUT_MS = Number.parseInt(process.env.FREE_MODEL_MATRIX_TIMEOUT_MS || '180000', 10);

const { MODEL_PRICING, estimateCost } = await import('../dist/pricing.js');
Expand Down
6 changes: 3 additions & 3 deletions test/local.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import { dirname, join } from 'node:path';
import { homedir, tmpdir } from 'node:os';
import { fileURLToPath } from 'node:url';

const DIST = new URL('../dist/index.js', import.meta.url).pathname;
const DIST = fileURLToPath(new URL('../dist/index.js', import.meta.url));
const REPO_ROOT = fileURLToPath(new URL('..', import.meta.url));

function runCli(prompt = '', { cwd, timeoutMs = 15_000, args, env } = {}) {
Expand Down Expand Up @@ -818,7 +818,7 @@ test('resume: second interactiveSession with resumeSessionId continues prior tra

test('pruneOldSessions removes stale ghost sessions even when visible session count is below the cap', async () => {
const fakeHome = mkdtempSync(join(tmpdir(), 'franklin-ghost-prune-'));
const storagePath = new URL('../dist/session/storage.js', import.meta.url).pathname;
const storagePath = fileURLToPath(new URL('../dist/session/storage.js', import.meta.url));

try {
const sessionsDir = join(fakeHome, '.blockrun', 'sessions');
Expand Down Expand Up @@ -895,7 +895,7 @@ test('pruneOldSessions removes stale ghost sessions even when visible session co

test('session meta imported flag can be set and survives later updates', async () => {
const fakeHome = mkdtempSync(join(tmpdir(), 'franklin-imported-meta-'));
const storagePath = new URL('../dist/session/storage.js', import.meta.url).pathname;
const storagePath = fileURLToPath(new URL('../dist/session/storage.js', import.meta.url));
try {
const result = await new Promise((resolve, reject) => {
const proc = spawn('node', [
Expand Down
3 changes: 2 additions & 1 deletion test/skills.local.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,13 +11,14 @@ import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { tmpdir } from 'node:os';
import { spawn } from 'node:child_process';
import { fileURLToPath } from 'node:url';

import { parseSkill, loadSkillsFromDir } from '../dist/skills/loader.js';
import { substituteVariables, matchSkill } from '../dist/skills/invoke.js';
import { Registry } from '../dist/skills/registry.js';
import { loadBundledSkills, getSkillVars } from '../dist/skills/bootstrap.js';

const DIST = new URL('../dist/index.js', import.meta.url).pathname;
const DIST = fileURLToPath(new URL('../dist/index.js', import.meta.url));

function runCli(args, { timeoutMs = 8000 } = {}) {
return new Promise((resolve, reject) => {
Expand Down