Don't report missing files from upload staging directory (BL-16113)#7807
Open
andrew-polk wants to merge 1 commit intoVersion6.3from
Open
Don't report missing files from upload staging directory (BL-16113)#7807andrew-polk wants to merge 1 commit intoVersion6.3from
andrew-polk wants to merge 1 commit intoVersion6.3from
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/BloomExe/web/BloomServer.cs">
<violation number="1" location="src/BloomExe/web/BloomServer.cs:1958">
P2: The `/Temp/` prefix makes this filter platform-specific. On Linux the temp directory is `/tmp/`, so `"/temp/bloomuploadstaging"` won't match paths like `/tmp/BloomUploadStaging0/...`. The adjacent entries (`kEPUBExportFolder`, `BRExportFolder`) use just the folder name without a path prefix. Do the same here for cross-platform correctness and consistency.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
| // of controls we hide for things like adding books to collection, displaying the collection, playing audio (that last we might want back one day). | ||
| EpubMaker.kEPUBExportFolder.ToLowerInvariant(), | ||
| BloomPubMaker.BRExportFolder.ToLowerInvariant(), | ||
| "/Temp/BloomUploadStaging".ToLowerInvariant(), |
There was a problem hiding this comment.
P2: The /Temp/ prefix makes this filter platform-specific. On Linux the temp directory is /tmp/, so "/temp/bloomuploadstaging" won't match paths like /tmp/BloomUploadStaging0/.... The adjacent entries (kEPUBExportFolder, BRExportFolder) use just the folder name without a path prefix. Do the same here for cross-platform correctness and consistency.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/BloomExe/web/BloomServer.cs, line 1958:
<comment>The `/Temp/` prefix makes this filter platform-specific. On Linux the temp directory is `/tmp/`, so `"/temp/bloomuploadstaging"` won't match paths like `/tmp/BloomUploadStaging0/...`. The adjacent entries (`kEPUBExportFolder`, `BRExportFolder`) use just the folder name without a path prefix. Do the same here for cross-platform correctness and consistency.</comment>
<file context>
@@ -1955,6 +1955,7 @@ protected bool ShouldReportFailedRequest(
// of controls we hide for things like adding books to collection, displaying the collection, playing audio (that last we might want back one day).
EpubMaker.kEPUBExportFolder.ToLowerInvariant(),
BloomPubMaker.BRExportFolder.ToLowerInvariant(),
+ "/Temp/BloomUploadStaging".ToLowerInvariant(),
// old quiz pages ask for this script, but it's now bundled with rest of edit code
"simplecomprehensionquiz.js",
</file context>
Suggested change
| "/Temp/BloomUploadStaging".ToLowerInvariant(), | |
| "bloomuploadstaging", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is