Skip to content

Don't report missing files from upload staging directory (BL-16113) #7807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andrew-polk wants to merge 1 commit into
base: Version6.3
Choose a base branch
from
+1 −0
Open

Don't report missing files from upload staging directory (BL-16113) #7807

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/BloomExe/web/BloomServer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1955,6 +1955,7 @@ protected bool ShouldReportFailedRequest(
// of controls we hide for things like adding books to collection, displaying the collection, playing audio (that last we might want back one day).
EpubMaker.kEPUBExportFolder.ToLowerInvariant(),
BloomPubMaker.BRExportFolder.ToLowerInvariant(),
"/Temp/BloomUploadStaging".ToLowerInvariant(),
Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai bot Apr 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: The /Temp/ prefix makes this filter platform-specific. On Linux the temp directory is /tmp/, so "/temp/bloomuploadstaging" won't match paths like /tmp/BloomUploadStaging0/.... The adjacent entries (kEPUBExportFolder, BRExportFolder) use just the folder name without a path prefix. Do the same here for cross-platform correctness and consistency.

Prompt for AI agents 
Check if this issue is valid — if so, understand the root cause and fix it. At src/BloomExe/web/BloomServer.cs, line 1958:

<comment>The `/Temp/` prefix makes this filter platform-specific. On Linux the temp directory is `/tmp/`, so `"/temp/bloomuploadstaging"` won't match paths like `/tmp/BloomUploadStaging0/...`. The adjacent entries (`kEPUBExportFolder`, `BRExportFolder`) use just the folder name without a path prefix. Do the same here for cross-platform correctness and consistency.</comment>

<file context>
@@ -1955,6 +1955,7 @@ protected bool ShouldReportFailedRequest(
                 // of controls we hide for things like adding books to collection, displaying the collection, playing audio (that last we might want back one day).
                 EpubMaker.kEPUBExportFolder.ToLowerInvariant(),
                 BloomPubMaker.BRExportFolder.ToLowerInvariant(),
+                "/Temp/BloomUploadStaging".ToLowerInvariant(),
                 // old quiz pages ask for this script, but it's now bundled with rest of edit code
                 "simplecomprehensionquiz.js",
</file context>
Suggested change
"/Temp/BloomUploadStaging".ToLowerInvariant(),
"bloomuploadstaging",
Fix with Cubic

// old quiz pages ask for this script, but it's now bundled with rest of edit code
"simplecomprehensionquiz.js",
// bloom-player always asks for questions.json for every book.
Expand Down