fix: create deployment directory before writing -latest.json#3
Merged
Conversation
When all deployments are skipped (contracts already on-chain), the
deployments/{category}/ directory may not exist yet because it is
normally created inside __deploy() via _saveContractToStandardJsonInput.
Ensure the directory exists before vm.writeJson to prevent "No such
file or directory" errors on retry runs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2. When all deployments are skipped (contracts already exist on-chain), the
deployments/{category}/directory may not exist because it is normally created inside__deploy()→_saveContractToStandardJsonInput(). This causesvm.writeJsonto fail with "No such file or directory" on retry runs.vm.createDir(..., true)before writing-latest.json, matching the existing pattern at line 796vm.createDirwithtrueismkdir -p— no-op if directory already existsTest plan
forge buildcompilesdeployments/folder entirely, re-run — verify-latest.jsonis created