Fsm refactor #154
Fsm refactor #154
Conversation
Zolkin1
left a comment
Zolkin1
left a comment
There was a problem hiding this comment.
Overall looks good. just a few questions
| # ----- High Level/Execution FSM Controller ----- # | ||
| - pkg: obelisk_unitree_cpp | ||
| executable: obelisk_unitree_joystick | ||
| # params: |
There was a problem hiding this comment.
Should we just delete these? Or do we want to keep them commented out?
There was a problem hiding this comment.
Can even uncomment them, they work and will be used often downstream. Doesn't really matter for this script.Could also remove.
There was a problem hiding this comment.
You wanna remove this one and the next one? Then we can merge
| executable: obelisk_unitree_go2_hardware | ||
| params: | ||
| network_interface_name: enp4s0 #enx001cc24ce09a | ||
| network_interface_name: enx6c1ff724e92e |
There was a problem hiding this comment.
We could remove this entirely now, right?
There was a problem hiding this comment.
You can still pass the network interface if you prefer (but I would still remove this). It looks for network interface first, then ip address. I would remove.
There was a problem hiding this comment.
You wanna go ahead and remove this one too?
Zolkin1
left a comment
Zolkin1
left a comment
There was a problem hiding this comment.
lgtm. just remove the two parts in the comments then feel free to merge.
| # ----- High Level/Execution FSM Controller ----- # | ||
| - pkg: obelisk_unitree_cpp | ||
| executable: obelisk_unitree_joystick | ||
| # params: |
There was a problem hiding this comment.
You wanna remove this one and the next one? Then we can merge
| executable: obelisk_unitree_go2_hardware | ||
| params: | ||
| network_interface_name: enp4s0 #enx001cc24ce09a | ||
| network_interface_name: enx6c1ff724e92e |
There was a problem hiding this comment.
You wanna go ahead and remove this one too?
Refactored the Unitree FSM with several improvements, including