BDMS-540: Link NMA_SurfaceWaterPhotos to NMA_SurfaceWaterData#469
Merged
jirhiker merged 5 commits intokas-bdms-540-NMA_WeatherData-FK-relationshipfrom Feb 7, 2026
Conversation
…os and NMA_SurfaceWaterData via SurfaceID - make NMA_SurfaceWaterData.surface_id unique to support FK target - add FK + relationship on NMA_SurfaceWaterPhotos.surface_id with validation - enforce parent-first ordering by running SurfaceWaterPhotos after SurfaceWaterData - skip orphan photo rows in transfer using cached SurfaceIDs - add migration to backfill/cleanup and enforce NOT NULL + FK - update legacy tests to create photos with real parent SurfaceWaterData
ksmuczynski
requested review from
TylerAdamMartinez,
jacob-a-brown and
jirhiker
…NMA_WeatherPhotos via WeatherID - move weather_id under FK section and enforce NOT NULL - add FK + relationship + validator on NMA_WeatherPhotos - mark NMA_WeatherData.weather_id unique for FK target - run WeatherPhotos transfer after WeatherData and skip orphan photos - add migration to backfill/cleanup and enforce FK/NOT NULL - update legacy tests to create WeatherPhotos with a real parent WeatherData
ksmuczynski
changed the title
Member
|
See comment on PR#470 |
…atherPhotos-FK-relationship BDMS-540: Link NMA_WeatherPhotos to NMA_WeatherData
jirhiker
merged commit 393c553
into
kas-bdms-540-NMA_WeatherData-FK-relationship
4 checks passed
TylerAdamMartinez
deleted the
kas-bdms-540-NMA_SurfaceWaterPhotos-FK-relationship
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
This PR addresses the following problem / context:
NMA_SurfaceWaterPhotoslacked a direct FK relationship to SurfaceWaterData, making joins and integrity checks harder.How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?