fix: update fastapi version and correct variable name for sample poin…#499
fix: update fastapi version and correct variable name for sample poin…#499
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b423397401
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fastapi==0.128.0 \ | ||
| --hash=sha256:6314385777a507bb19b34bd064829fddaea0eea54436deb632b5de587554055c \ | ||
| --hash=sha256:72e188f01f360e2f59da51c8822cbe4bca210c35daaae6321b1b724109101c00 |
There was a problem hiding this comment.
The requirement was updated to fastapi==0.128.0, but the two hashes on this entry are still the previous release hashes (they no longer match the 0.128.0 artifacts recorded in uv.lock around the FastAPI package block). Any environment installing from this pinned, hash-based requirements file in hash-checking mode (e.g., pip install --require-hashes -r requirements.txt) will fail with a hash mismatch and block dependency installation.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s FastAPI dependency and adjusts the MinorTraceChemistry transfer upsert mapping for the legacy SamplePointID field.
Changes:
- Bump FastAPI from
0.124.2to0.128.0across dependency manifests/locks. - Update the MinorTraceChemistry upsert
set_mapping to usenma_SamplePointID.
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
uv.lock |
Locks FastAPI to 0.128.0 with updated artifact metadata. |
requirements.txt |
Pins FastAPI to 0.128.0 (but hashes need regeneration). |
pyproject.toml |
Updates project dependency pin for FastAPI to 0.128.0. |
transfers/minor_trace_chemistry_transfer.py |
Adjusts upsert update mapping key for SamplePointID. |
| "chemistry_sample_info_id": excluded.chemistry_sample_info_id, | ||
| "nma_chemistry_sample_info_uuid": excluded.nma_chemistry_sample_info_uuid, | ||
| "nma_sample_point_id": excluded.nma_sample_point_id, | ||
| "nma_SamplePointID": excluded.nma_SamplePointID, |
There was a problem hiding this comment.
The upsert set_ mapping now uses nma_SamplePointID, but _row_to_dict() still populates nma_sample_point_id for inserts (and tests assert that key). This means inserts and conflict-updates are using different column keys and is likely to raise “unconsumed column names”/missing attribute errors or silently skip updates depending on SQLAlchemy’s column key resolution. Align on a single key (most other transfers use the DB column name nma_SamplePointID) and update _row_to_dict() and its tests accordingly.
| "nma_SamplePointID": excluded.nma_SamplePointID, | |
| "nma_sample_point_id": excluded.nma_sample_point_id, |
…t ID
Why
This PR addresses the following problem / context:
How
Implementation summary - the following was changed / added / removed:
Notes
Any special considerations, workarounds, or follow-up work to note?