Skip to content

fix: update fastapi version and correct variable name for sample poin… #499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jirhiker merged 1 commit into from
Feb 13, 2026
Merged

fix: update fastapi version and correct variable name for sample poin… #499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ dependencies = [
"dnspython==2.8.0",
"dotenv==0.9.9",
"email-validator==2.3.0",
"fastapi==0.124.2",
"fastapi==0.128.0",
"fastapi-pagination==0.15.10",
"frozenlist==1.8.0",
"geoalchemy2==0.18.1",
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -393,7 +393,7 @@ email-validator==2.3.0 \
--hash=sha256:80f13f623413e6b197ae73bb10bf4eb0908faf509ad8362c5edeb0be7fd450b4 \
--hash=sha256:9fc05c37f2f6cf439ff414f8fc46d917929974a82244c20eb10231ba60c54426
# via ocotilloapi
fastapi==0.124.2 \
fastapi==0.128.0 \
--hash=sha256:6314385777a507bb19b34bd064829fddaea0eea54436deb632b5de587554055c \
--hash=sha256:72e188f01f360e2f59da51c8822cbe4bca210c35daaae6321b1b724109101c00
Comment on lines +396 to 398
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Regenerate FastAPI hashes after version bump

The requirement was updated to fastapi==0.128.0, but the two hashes on this entry are still the previous release hashes (they no longer match the 0.128.0 artifacts recorded in uv.lock around the FastAPI package block). Any environment installing from this pinned, hash-based requirements file in hash-checking mode (e.g., pip install --require-hashes -r requirements.txt) will fail with a hash mismatch and block dependency installation.

Useful? React with 👍 / 👎.

# via
Expand Down
2 changes: 1 addition & 1 deletion transfers/minor_trace_chemistry_transfer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ def _transfer_hook(self, session: Session) -> None:
set_={
"chemistry_sample_info_id": excluded.chemistry_sample_info_id,
"nma_chemistry_sample_info_uuid": excluded.nma_chemistry_sample_info_uuid,
"nma_sample_point_id": excluded.nma_sample_point_id,
"nma_SamplePointID": excluded.nma_SamplePointID,
Copy link

Copilot AI Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The upsert set_ mapping now uses nma_SamplePointID, but _row_to_dict() still populates nma_sample_point_id for inserts (and tests assert that key). This means inserts and conflict-updates are using different column keys and is likely to raise “unconsumed column names”/missing attribute errors or silently skip updates depending on SQLAlchemy’s column key resolution. Align on a single key (most other transfers use the DB column name nma_SamplePointID) and update _row_to_dict() and its tests accordingly.

Suggested change
"nma_SamplePointID": excluded.nma_SamplePointID,
"nma_sample_point_id": excluded.nma_sample_point_id,

Copilot uses AI. Check for mistakes.
"sample_value": excluded.sample_value,
"units": excluded.units,
"symbol": excluded.symbol,
Expand Down
10 changes: 5 additions & 5 deletions uv.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading