Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/snippets/other.6558.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
- (#6558) Annotate the UI file `orders.lua`.
1 change: 1 addition & 0 deletions engine/User/UserUnit.lua
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
---@class UserUnit: InternalObject
---@field ThreadUnpause? thread
---@field ThreadUnpauseCandidates? table<EntityId, boolean>
---@field Dead boolean
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This value only exists for the Sim Unit. The references to it in orders.lua are from a large engine-call refactor in 63e81c4, which caught the User version of IsDead.

Suggested change
---@field Dead boolean

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in the PR with the suggestions*

local UserUnit = {}

---@alias UserUnitCommand
Expand Down
2 changes: 1 addition & 1 deletion lua/keymap/misckeyactions.lua
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,7 @@ function CreateTemplateFactory()
end

--- Creates a sim callback to set the priorities of the selected units
---@param prioritiesString string A string of categories
---@param prioritiesString string | number A string of categories
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I address this more extensively in #6680, but it suffices to fix the warnings in order.lua.

---@param name string Name of the priority set, used when printing on screen
---@param exclusive boolean ??
function SetWeaponPriorities(prioritiesString, name, exclusive)
Expand Down
Loading