-
Notifications
You must be signed in to change notification settings - Fork 252
annotate orders.lua #6558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
clyfordv
wants to merge
7
commits into
FAForever:develop
Choose a base branch
from
clyfordv:OrdersLuaAnnotations
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+137
−17
Open
annotate orders.lua #6558
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
2ead33e
changelog
clyfordv 1402357
orders.lua annotations and error elimination
clyfordv 9564d5f
changelog
clyfordv 54eb5d1
fix malformed changelog snippet name
clyfordv fed179a
Delete features.6557.md
lL1l1 e30b8fa
Update snippet formatting
lL1l1 0942eaa
Merge branch 'develop' into pr/6558
lL1l1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| - (#6558) Annotate the UI file `orders.lua`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -380,7 +380,7 @@ function CreateTemplateFactory() | |
| end | ||
|
|
||
| --- Creates a sim callback to set the priorities of the selected units | ||
| ---@param prioritiesString string A string of categories | ||
| ---@param prioritiesString string | number A string of categories | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I address this more extensively in #6680, but it suffices to fix the warnings in |
||
| ---@param name string Name of the priority set, used when printing on screen | ||
| ---@param exclusive boolean ?? | ||
| function SetWeaponPriorities(prioritiesString, name, exclusive) | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value only exists for the Sim Unit. The references to it in
orders.luaare from a large engine-call refactor in 63e81c4, which caught the User version ofIsDead.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in the PR with the suggestions*