Add action to check SpatialData.plot on changes to SpatialData#180
Add action to check SpatialData.plot on changes to SpatialData#180Bisaloo wants to merge 4 commits into
Conversation
|
Hmm, but this does not look like its pulling the changes in the associated commit of sd ? so it will only pull from the main branch of sd. i was thinking more like seeing the immediate effects of one's commit/PR on sd.plot. |
|
Yes, you're right. We can tweak this with GHA variables by specifying a specific SpatialData version (the commit in question) in: - uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: any::rcmdcheck
needs: checkThe idea of this PR was mostly to show one approach I like and see if you like it as well. We can tweak if you agree with the general approach. |
|
Yes, I agree this looks clean! please do ... |
|
Ah ok, you get a conflict with sd.plot's sd dependency. |
|
The original solution is cleaner but perhaps it is too hard to update. Should we instead add a step to the |
|
Yeah, that's disappointing because this would work perfectly as soon as SpatialData is on Bioconductor. It's failing because of the Loosely related but I would recommend splitting the existing worfklow into more standard workflows, such as done in, e.g., SpatialData.plot. I think the biocthis workflow difficult to maintain. |
Fix #179