Skip to content

Add action to check SpatialData.plot on changes to SpatialData#180

Open
Bisaloo wants to merge 4 commits into
HelenaLC:mainfrom
Bisaloo:test-spatialdataplot
Open

Add action to check SpatialData.plot on changes to SpatialData#180
Bisaloo wants to merge 4 commits into
HelenaLC:mainfrom
Bisaloo:test-spatialdataplot

Conversation

@Bisaloo
Copy link
Copy Markdown
Contributor

@Bisaloo Bisaloo commented May 7, 2026

Fix #179

@Artur-man
Copy link
Copy Markdown
Collaborator

Artur-man commented May 7, 2026

Hmm, but this does not look like its pulling the changes in the associated commit of sd ? so it will only pull from the main branch of sd. i was thinking more like seeing the immediate effects of one's commit/PR on sd.plot.

@Bisaloo
Copy link
Copy Markdown
Contributor Author

Bisaloo commented May 7, 2026

Yes, you're right. We can tweak this with GHA variables by specifying a specific SpatialData version (the commit in question) in:

      - uses: r-lib/actions/setup-r-dependencies@v2
        with:
          extra-packages: any::rcmdcheck
          needs: check

The idea of this PR was mostly to show one approach I like and see if you like it as well. We can tweak if you agree with the general approach.

@Artur-man
Copy link
Copy Markdown
Collaborator

Yes, I agree this looks clean! please do ...

@Artur-man
Copy link
Copy Markdown
Collaborator

Artur-man commented May 7, 2026

Ah ok, you get a conflict with sd.plot's sd dependency.

@Artur-man
Copy link
Copy Markdown
Collaborator

Artur-man commented May 9, 2026

The original solution is cleaner but perhaps it is too hard to update. Should we instead add a step to the check.yml job instead of another action?

@Bisaloo
Copy link
Copy Markdown
Contributor Author

Bisaloo commented May 9, 2026

Yeah, that's disappointing because this would work perfectly as soon as SpatialData is on Bioconductor. It's failing because of the Remotes: fields in DESCRIPTION.

Loosely related but I would recommend splitting the existing worfklow into more standard workflows, such as done in, e.g., SpatialData.plot. I think the biocthis workflow difficult to maintain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Testing SpatialData.plot

2 participants