feat: Introduce Flake for development and builds#2121
Open
shymega wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Open
feat: Introduce Flake for development and builds#2121shymega wants to merge 1 commit intoInfiniTimeOrg:mainfrom
shymega wants to merge 1 commit intoInfiniTimeOrg:mainfrom
Conversation
Contributor
Author
|
I'm keeping this as a draft for now, because I want to check with the I also wanted to ask if the Thanks. |
Contributor
Author
|
We also need to document the Flake, and possibly add CI. I can add the CI workflows to a new PR if needed. However, I'm not sure how |
|
Build size and comparison to main:
|
shymega
force-pushed
the
shymega-feat/nix-flake
branch
2 times, most recently
from
46daf79 to
a9a3679
Compare
shymega
force-pushed
the
shymega-feat/nix-flake
branch
8 times, most recently
from
7606e37 to
c613bc7
Compare
shymega
force-pushed
the
shymega-feat/nix-flake
branch
from
c613bc7 to
cb12758
Compare
shymega
added a commit
to shymega/InfiniSim
that referenced
this pull request
Nov 13, 2024
This PR introduces a Nix flake, allowing for InfiniSim to be built as a Flake, including a FHS development environment. We also introduce `flake-compat`, allowing for non-Flake Nix mahcines to use the project as-is, both for building (`default.nix`), and development (`shell.nix`). Additionally, we introduce `.envrc`, meaning that with `direnv`, the Nix Flake is activated automatically. It should be noted that we require InfiniTimeOrg/InfiniTime#2121 to be merged into mainline before this PR will work. It will currently fail - this is expected at this stage. A lockfile needs to be generated after the above PR is merged - this PR here should NOT be merged until that is completed. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Contributor
Author
|
This PR is now ready for review. It is currently blocking InfiniTimeOrg/InfiniSim#148, but once this PR merged, the [InfiniSim] one will be ready to be merged too |
shymega
force-pushed
the
shymega-feat/nix-flake
branch
from
cb12758 to
f521883
Compare
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 14, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 14, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 14, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 15, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 15, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 15, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
added a commit
to shymega/InfiniTime
that referenced
this pull request
Nov 15, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
JF002
pushed a commit
that referenced
this pull request
Nov 17, 2024
This fixes CI on #2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
force-pushed
the
shymega-feat/nix-flake
branch
from
f521883 to
7f792f1
Compare
jmlich
pushed a commit
to jmlich/InfiniTime
that referenced
this pull request
Dec 22, 2024
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
BurninTurtles
pushed a commit
to BurninTurtles/InfiniTimeBT
that referenced
this pull request
Mar 3, 2025
This fixes CI on InfiniTimeOrg#2121. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
Contributor
|
As someone with no Nix knowledge what steps must I take to test this PR locally? |
Contributor
Author
|
@NeroBurner You would first need to install the Nix package manager. In terms of testing, you could test the Flake is correct by running |
Contributor
Author
|
The same principle would apply to InfiniSim :) |
shymega
force-pushed
the
shymega-feat/nix-flake
branch
from
7f792f1 to
1008870
Compare
Contributor
Author
|
I should also probably add CI checks for the Nix Flake to this PR and InfiniSim. Thoughts? |
This PR introduces a Nix flake, allowing for InfiniTime to be built as a Flake, including a FHS development environment. It's derived from InfiniTimeOrg#1850 and icewind1991/infinitime-builder@c57c57f. We also introduce `flake-compat`, allowing for non-Flake Nix mahcines to use the project as-is, both for building (`default.nix`), and development (`shell.nix`). Additionally, we introduce `.envrc`, meaning that with `direnv`, the Nix Flake is activated automatically. Fixes InfiniTimeOrg#1850. Signed-off-by: Dom Rodriguez <shymega@shymega.org.uk>
shymega
force-pushed
the
shymega-feat/nix-flake
branch
from
1008870 to
80a1148
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a Nix flake, allowing for InfiniTime to be built as a Flake, including a FHS development environment.
It's derived from #1850 and
icewind1991/infinitime-builder@c57c57f.
We also introduce
flake-compat, allowing for non-Flake Nix mahcines to use the project as-is, both for building (default.nix), and development (shell.nix).Additionally, we introduce
.envrc, meaning that withdirenv, the Nix Flake is activated automatically.Fixes #1850.