Skip to content

Fix some tests#767

Merged
christiangnrd merged 3 commits intomasterfrom
fixtest
Feb 26, 2026
Merged

Fix some tests#767
christiangnrd merged 3 commits intomasterfrom
fixtest

Conversation

@christiangnrd
Copy link
Member

Potentially SPIRV-related commits (haven't confirmed): JuliaLang/julia#60695 & JuliaLang/julia@3c92c84

Precompile-related commits: JuliaLang/julia#60741 & JuliaLang/julia#60747

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2026

Your PR requires formatting changes to meet the project's style guidelines.
Please consider running Runic (git runic master) to apply these changes.

Click here to view the suggested changes.
diff --git a/test/native/precompile.jl b/test/native/precompile.jl
index 1d18682..65ef61f 100644
--- a/test/native/precompile.jl
+++ b/test/native/precompile.jl
@@ -76,7 +76,7 @@ precompile_test_harness("Inference caching") do load_path
         @test check_presence(square_mi, token)
 
         # check that identity survived
-        @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION>=v"1.13.0-")
+        @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION >= v"1.13.0-")
 
         GPUCompiler.clear_disk_cache!()
         @test GPUCompiler.disk_cache_enabled() == false
diff --git a/test/ptx/precompile.jl b/test/ptx/precompile.jl
index 4e66926..c89f37c 100644
--- a/test/ptx/precompile.jl
+++ b/test/ptx/precompile.jl
@@ -49,6 +49,6 @@ precompile_test_harness("Inference caching") do load_path
         @test check_presence(kernel_mi, token)
 
         # check that identity survived
-        @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION>=v"1.13.0-")
+        @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION >= v"1.13.0-")
     end
 end
diff --git a/test/spirv.jl b/test/spirv.jl
index 1384a73..5256d28 100644
--- a/test/spirv.jl
+++ b/test/spirv.jl
@@ -133,16 +133,16 @@ end
         # TODO: should structs of `NTuple{VecElement{T}}` be passed by value instead of sret?
         check"CHECK-NOT: i128"
         check"CHECK-LABEL: define void @{{(julia|j)_kernel_[0-9]+}}"
-        @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca <2 x i64>, align 16"
-        @static VERSION >= v"1.12.5" && check"CHECK: alloca [2 x i64], align 16"
+            @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca <2 x i64>, align 16"
+            @static VERSION >= v"1.12.5" && check"CHECK: alloca [2 x i64], align 16"
         SPIRV.code_llvm(mod.kernel, NTuple{2, mod.Vec{4, Float32}}; backend, dump_module=true)
     end
 
     @test @filecheck begin
         check"CHECK-NOT: i128"
         check"CHECK-LABEL: define void @{{(julia|j)_kernel_[0-9]+}}"
-        @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca [2 x <2 x i64>], align 16"
-        @static VERSION >= v"1.12.5" && check"CHECK: alloca [4 x i64], align 16"
+            @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca [2 x <2 x i64>], align 16"
+            @static VERSION >= v"1.12.5" && check"CHECK: alloca [4 x i64], align 16"
         SPIRV.code_llvm(mod.kernel, NTuple{2, mod.Vec{8, Float32}}; backend, dump_module=true)
     end
 end

@christiangnrd
Copy link
Member Author

christiangnrd commented Feb 25, 2026

gnuassert test failing because the build failed when bumping the version to 1.12.5 so it thinks it's running 1.12.4 but includes the fixes. Not sure it's worth the effort to fix this

Also buildkite shows up as failing because I pushed a temporary commit that canceled the current build, but I reverted it and github shows the cancelled build. https://buildkite.com/julialang/gpucompiler-dot-jl/builds/2185 should be used

@christiangnrd christiangnrd merged commit 61e84b0 into master Feb 26, 2026
119 of 147 checks passed
@christiangnrd christiangnrd deleted the fixtest branch February 26, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants