Skip to content

Fix some tests #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
christiangnrd merged 3 commits into from
Feb 26, 2026
Merged

Fix some tests #767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27c4e29
Fix SPIRV tests after 1.12.5
christiangnrd Feb 25, 2026
31de35a
Fix precompile tests
christiangnrd Feb 25, 2026
ebbb77f
Formatting
christiangnrd Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/native/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ precompile_test_harness("Inference caching") do load_path
A[1] = x
return
end

function kernel_w_global(A, x, sym)
if sym == :A
A[1] = x
Expand Down Expand Up @@ -76,7 +76,7 @@ precompile_test_harness("Inference caching") do load_path
@test check_presence(square_mi, token)

# check that identity survived
@test check_presence(identity_mi, token) broken=VERSION>=v"1.12.0-DEV.1268"
@test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION>=v"1.13.0-")

GPUCompiler.clear_disk_cache!()
@test GPUCompiler.disk_cache_enabled() == false
Expand Down
2 changes: 1 addition & 1 deletion test/ptx/precompile.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,6 @@ precompile_test_harness("Inference caching") do load_path
@test check_presence(kernel_mi, token)

# check that identity survived
@test check_presence(identity_mi, token) broken=VERSION>=v"1.12.0-DEV.1268"
@test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION>=v"1.13.0-")
end
end
6 changes: 4 additions & 2 deletions test/spirv.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,14 +133,16 @@ end
# TODO: should structs of `NTuple{VecElement{T}}` be passed by value instead of sret?
check"CHECK-NOT: i128"
check"CHECK-LABEL: define void @{{(julia|j)_kernel_[0-9]+}}"
@static VERSION >= v"1.12" && check"CHECK: alloca <2 x i64>, align 16"
@static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca <2 x i64>, align 16"
@static VERSION >= v"1.12.5" && check"CHECK: alloca [2 x i64], align 16"
SPIRV.code_llvm(mod.kernel, NTuple{2, mod.Vec{4, Float32}}; backend, dump_module=true)
end

@test @filecheck begin
check"CHECK-NOT: i128"
check"CHECK-LABEL: define void @{{(julia|j)_kernel_[0-9]+}}"
@static VERSION >= v"1.12" && check"CHECK: alloca [2 x <2 x i64>], align 16"
@static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca [2 x <2 x i64>], align 16"
@static VERSION >= v"1.12.5" && check"CHECK: alloca [4 x i64], align 16"
SPIRV.code_llvm(mod.kernel, NTuple{2, mod.Vec{8, Float32}}; backend, dump_module=true)
end
end
Expand Down
Loading