Merged
Conversation
Potentially related to JuliaLang/julia#60695
Contributor
|
Your PR requires formatting changes to meet the project's style guidelines. Click here to view the suggested changes.diff --git a/test/native/precompile.jl b/test/native/precompile.jl
index 1d18682..65ef61f 100644
--- a/test/native/precompile.jl
+++ b/test/native/precompile.jl
@@ -76,7 +76,7 @@ precompile_test_harness("Inference caching") do load_path
@test check_presence(square_mi, token)
# check that identity survived
- @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION>=v"1.13.0-")
+ @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION >= v"1.13.0-")
GPUCompiler.clear_disk_cache!()
@test GPUCompiler.disk_cache_enabled() == false
diff --git a/test/ptx/precompile.jl b/test/ptx/precompile.jl
index 4e66926..c89f37c 100644
--- a/test/ptx/precompile.jl
+++ b/test/ptx/precompile.jl
@@ -49,6 +49,6 @@ precompile_test_harness("Inference caching") do load_path
@test check_presence(kernel_mi, token)
# check that identity survived
- @test check_presence(identity_mi, token) broken=(v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION>=v"1.13.0-")
+ @test check_presence(identity_mi, token) broken = (v"1.12.0-DEV.1268" <= VERSION < v"1.12.5" || VERSION >= v"1.13.0-")
end
end
diff --git a/test/spirv.jl b/test/spirv.jl
index 1384a73..5256d28 100644
--- a/test/spirv.jl
+++ b/test/spirv.jl
@@ -133,16 +133,16 @@ end
# TODO: should structs of `NTuple{VecElement{T}}` be passed by value instead of sret?
check"CHECK-NOT: i128"
check"CHECK-LABEL: define void @{{(julia|j)_kernel_[0-9]+}}"
- @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca <2 x i64>, align 16"
- @static VERSION >= v"1.12.5" && check"CHECK: alloca [2 x i64], align 16"
+ @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca <2 x i64>, align 16"
+ @static VERSION >= v"1.12.5" && check"CHECK: alloca [2 x i64], align 16"
SPIRV.code_llvm(mod.kernel, NTuple{2, mod.Vec{4, Float32}}; backend, dump_module=true)
end
@test @filecheck begin
check"CHECK-NOT: i128"
check"CHECK-LABEL: define void @{{(julia|j)_kernel_[0-9]+}}"
- @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca [2 x <2 x i64>], align 16"
- @static VERSION >= v"1.12.5" && check"CHECK: alloca [4 x i64], align 16"
+ @static v"1.12" <= VERSION < v"1.12.5" && check"CHECK: alloca [2 x <2 x i64>], align 16"
+ @static VERSION >= v"1.12.5" && check"CHECK: alloca [4 x i64], align 16"
SPIRV.code_llvm(mod.kernel, NTuple{2, mod.Vec{8, Float32}}; backend, dump_module=true)
end
end |
maleadt
reviewed
Feb 25, 2026
e69acf7 to
ebbb77f
Compare
Member
Author
|
gnuassert test failing because the build failed when bumping the version to 1.12.5 so it thinks it's running 1.12.4 but includes the fixes. Not sure it's worth the effort to fix this Also buildkite shows up as failing because I pushed a temporary commit that canceled the current build, but I reverted it and github shows the cancelled build. https://buildkite.com/julialang/gpucompiler-dot-jl/builds/2185 should be used |
maleadt
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potentially SPIRV-related commits (haven't confirmed): JuliaLang/julia#60695 & JuliaLang/julia@3c92c84
Precompile-related commits: JuliaLang/julia#60741 & JuliaLang/julia#60747