refactor: clarify analyseImport variable name and return contract (#167)#178
Merged
Conversation
Rename seenNames -> allSeenNames to make the dual-accumulator role explicit, and add two inline comments clarifying that valid includes duplicates and that callers must consult the duplicates map. No behaviour changes. Fixes #167
# Conflicts: # modules/validation.js
# Conflicts: # modules/validation.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves readability of
analyseImportinmodules/validation.jswithout changing any behaviour:seenNames→allSeenNamesto make explicit that the Map accumulates both existing templates AND processed importsvalid = []clarifying it includes duplicatesvalid.push(t)pointing callers toduplicatesfor merge decisionsChanges
modules/validation.js: variable rename + 3 inline commentsTesting
No logic changes — all 96 existing tests pass.
Fixes #167