Skip to content

refactor: clarify analyseImport variable name and return contract (#167) #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JuliaKalder merged 3 commits into from
Jun 3, 2026
Merged

refactor: clarify analyseImport variable name and return contract (#167) #178

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31cf6eb
refactor: clarify analyseImport variable name and return contract
May 14, 2026
3951448
Merge remote-tracking branch 'origin/main' into fix/issue-167
Jun 3, 2026
508cae0
Merge remote-tracking branch 'origin/main' into fix/issue-167
Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions modules/validation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ export const ATTACHMENT_TOTAL_WARN_SIZE = 10 * 1024 * 1024;
* with either an existing template or another imported template.
*/
export function analyseImport(importedTemplates, existingTemplates) {
// Accumulates both existing and newly-imported names; used for duplicate
// detection. Note: `valid` may include entries that are also in `duplicates`.
const seenNames = new Map(
// Tracks all names seen so far: pre-seeded with existing template names
// for storage-level dedup, then extended with each processed import for
// intra-import dedup (so two imported templates with the same name both
// land in `duplicates`). Note: `valid` may include entries also in `duplicates`.
const allSeenNames = new Map(
existingTemplates
.filter((t) => t && typeof t.name === "string" && t.name.trim())
.map((t) => [t.name.toLowerCase(), t])
Expand All @@ -72,11 +74,11 @@ export function analyseImport(importedTemplates, existingTemplates) {
invalid++;
continue;
}
const key = (t.name || "").trim().toLowerCase();
if (seenNames.has(key)) {
const key = t.name.trim().toLowerCase();
if (allSeenNames.has(key)) {
duplicates.set(key, t);
}
seenNames.set(key, t);
allSeenNames.set(key, t);
if (t.body != null && typeof t.body !== "string") {
invalid++;
continue;
Expand Down