Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support quantified subquery predicates in
WHERE, includingANY,SOME, andALL.IN (subquery)is handled as= ANY (subquery)so it can share the same bind/planning/execution path.EXISTS (select *)is also allowed by avoiding scalar/quantified single-column output checks for EXISTS.Issue link:
What is changed and how it works?
MarkApplyQuantifier::{Any, All}and models quantified predicates withMarkApplyKind::Quantified.bind_subqueryreturns only the subquery plan/correlation state, whilebind_subquery_with_outputvalidates and returns the single output expression for scalar/quantified predicates.INasEq + Any, bindsANY/SOMEas quantified ANY, and bindsALLas quantified ALL.eq_any,eq_some,lt_any, andgt_allfor fields and query values, generated from a shared quantified comparison macro.Code changes
Check List
Tests
Manual test commands:
Side effects
Note for reviewer
IN (subquery)now displays/plans through quantified ANY (MarkAnyApply) instead of the previous IN-specific mark apply naming. The execution path still preserves the existing parameterized probe fast path for equality ANY/IN predicates.