feat(designs): add PE_INT implementation flow#58
Open
HLEE80 wants to merge 10 commits intoLinxISA:mainfrom
Open
feat(designs): add PE_INT implementation flow#58HLEE80 wants to merge 10 commits intoLinxISA:mainfrom
HLEE80 wants to merge 10 commits intoLinxISA:mainfrom
Conversation
Sync PE_INT into pycircuit designs with English docs/spec, pycc-relative build defaults, and WSL-ready regression scripts. Keep generated artifacts excluded from commit except deliverable generated Verilog.
Baseline the refreshed PE_INT PyCircuit design, generated RTL, model, RTL test environment, testcase suite, and supporting debug skills after full regression passed.
Consistent To English documentation Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Tighten generated RTL contracts and PE_INT implementation structure so the deliverables match review expectations for reset style, naming, Wallace reduction, and output state ownership.
Restore the PE_INT PyCircuit, generated RTL, and verification files to a coherent L=4 flow after local edits drifted out of sync.
Regenerate PE_INT with width-specific Wallace reductions and remove unused-signal suppression so Verilator can catch real dead logic.
Record optimizer topology status, regression evidence, and pre-push review gates so PE_INT closure is traceable beyond functional PASS. Co-authored-by: Cursor <cursoragent@cursor.com>
Keep PE_INT on public PyCircuit APIs, record the latest regression evidence, and add reviewer/scope guardrails for future PE_INT changes. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
python3 model/test_pe_int.pyunder WSL with PE_INT/PyCircuit PYTHONPATH.python3 python/build.py --target both --out-dir build/pe_int --jobs 8 --pyc-tb-vectors 8under WSL../build/pe_int/cpp_build/build/pyc_tb.bash sim/run_all_wsl.shcovering 9 RTL cases with bothiverilogandverilator -Wall.codereviewergate returnedPASS_WITH_NOTES; notes are limited to acceptedrst_nframework limitation and deferred Booth topology pending synthesis evidence.Notes
rst_nasync assertion / sync release mismatch is tracked as a known PyCircuit framework limitation.