Skip to content

feat(designs): add PE_INT implementation flow#58

Open
HLEE80 wants to merge 10 commits intoLinxISA:mainfrom
HLEE80:main
Open

feat(designs): add PE_INT implementation flow#58
HLEE80 wants to merge 10 commits intoLinxISA:mainfrom
HLEE80:main

Conversation

@HLEE80
Copy link
Copy Markdown

@HLEE80 HLEE80 commented May 7, 2026

Summary

  • Add the PE_INT PyCircuit design flow, generated RTL, model, and RTL/PyCircuit test environments.
  • Strengthen PE_INT verification with exact L=4 scoreboards, random-valid timing cases, public PyCircuit API usage, and generated RTL warning cleanup.
  • Add PE_INT flow guardrails, regression evidence, circuit optimizer documentation, and project-level codereviewer configuration.

Test plan

  • PASS: python3 model/test_pe_int.py under WSL with PE_INT/PyCircuit PYTHONPATH.
  • PASS: python3 python/build.py --target both --out-dir build/pe_int --jobs 8 --pyc-tb-vectors 8 under WSL.
  • PASS: ./build/pe_int/cpp_build/build/pyc_tb.
  • PASS: bash sim/run_all_wsl.sh covering 9 RTL cases with both iverilog and verilator -Wall.
  • PASS: Pre-PR codereviewer gate returned PASS_WITH_NOTES; notes are limited to accepted rst_n framework limitation and deferred Booth topology pending synthesis evidence.

Notes

  • rst_n async assertion / sync release mismatch is tracked as a known PyCircuit framework limitation.
  • Explicit radix-4 Booth multiplier topology remains documented as deferred until synthesis/timing/area evidence is available.

HLEE80 and others added 10 commits April 22, 2026 11:44
Sync PE_INT into pycircuit designs with English docs/spec, pycc-relative build defaults, and WSL-ready regression scripts. Keep generated artifacts excluded from commit except deliverable generated Verilog.
Baseline the refreshed PE_INT PyCircuit design, generated RTL, model, RTL test environment, testcase suite, and supporting debug skills after full regression passed.
Consistent To English documentation

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Tighten generated RTL contracts and PE_INT implementation structure so the deliverables match review expectations for reset style, naming, Wallace reduction, and output state ownership.
Restore the PE_INT PyCircuit, generated RTL, and verification files to a coherent L=4 flow after local edits drifted out of sync.
Regenerate PE_INT with width-specific Wallace reductions and remove unused-signal suppression so Verilator can catch real dead logic.
Record optimizer topology status, regression evidence, and pre-push review gates so PE_INT closure is traceable beyond functional PASS.

Co-authored-by: Cursor <cursoragent@cursor.com>
Keep PE_INT on public PyCircuit APIs, record the latest regression evidence, and add reviewer/scope guardrails for future PE_INT changes.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gemini-code-assist
Copy link
Copy Markdown

Warning

Gemini is experiencing higher than usual traffic and was unable to create the review. Please try again in a few hours by commenting /gemini review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant