Open
Conversation
HenryLeC
requested changes
Sep 15, 2025
Member
HenryLeC
left a comment
There was a problem hiding this comment.
A few ROS2 migration changes
Open
Open
… .launch file Co-authored-by: Henry LeCompte <henry@lunar-glass.com>
…2_mrobosub_teleop
Member
|
@HenryLeC Should parameter loading use the ros2 parameters or is just python yaml loading sufficient? |
Member
For this it probably isn't needed to load parameters using ROS2 but in general it allows for changing them at runtime if thats every something we need (It probably won't be). Its also just a more uniform interface so that each node can use the same bad parameter implementation instead of creating its own. ROS2 paramaters will also type check the yaml file and ensure all required params have values and switch the optional ones to their default. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #88
muskaan note: we also have to make some functionality changes to this code. arnav was saying he had some in mind so we can ask him.