Skip to content

data: List more already-implemented functions without symbols#911

Merged
MonsterDruide1 merged 1 commit into
masterfrom
listsym-work
Feb 23, 2026
Merged

data: List more already-implemented functions without symbols#911
MonsterDruide1 merged 1 commit into
masterfrom
listsym-work

Conversation

@MonsterDruide1
Copy link
Copy Markdown
Owner

@MonsterDruide1 MonsterDruide1 commented Feb 15, 2026

Working through the output of tools/listsym for a while, I created a few PRs on sead to fix how code is generated over there - but some functions are actually correctly implemented, but just do not expose a symbol in SMO, so we can add those to file_list.yml manually.


This change is Reviewable


Report for 1.0 (ae76c74 - 87c6d33)

📈 Matched code: 13.36% (+0.01%, +1180 bytes)

📈 1 improvement in an unmatched item
Unit Item Bytes Before After
Scene/SceneObjFactory sceneObjCreator(int) +208 0.00% 25.00%

@MonsterDruide1 MonsterDruide1 self-assigned this Feb 15, 2026
@github-actions github-actions Bot added the status:waiting for review This PR is ready to take the first or another look at it! label Feb 15, 2026
@MonsterDruide1 MonsterDruide1 added status:blocked This PR cannot be merged or reviewed at the moment - usually a PR in a library needs to be handled. and removed status:waiting for review This PR is ready to take the first or another look at it! labels Feb 15, 2026
@MonsterDruide1
Copy link
Copy Markdown
Owner Author

requires open-ead/sead#242 to match

@german77
Copy link
Copy Markdown
Contributor

Mentioned dependencies are merged. Needs rebase

@MonsterDruide1 MonsterDruide1 added status:waiting for review This PR is ready to take the first or another look at it! and removed status:blocked This PR cannot be merged or reviewed at the moment - usually a PR in a library needs to be handled. labels Feb 20, 2026
@MonsterDruide1
Copy link
Copy Markdown
Owner Author

Done, ready for review.

Copy link
Copy Markdown
Contributor

@german77 german77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_GLOBAL__sub_I_seadBoundBox.cpp wasn't possible to be located? to be fair I wasn't able to locate it either.

@german77 made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on MonsterDruide1).

@github-actions github-actions Bot added status:waiting for author Reviews have shown that the author of this PR needs to change some things. and removed status:waiting for review This PR is ready to take the first or another look at it! labels Feb 20, 2026
Copy link
Copy Markdown
Contributor

@german77 german77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@german77 reviewed 2 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on MonsterDruide1).

@github-actions github-actions Bot added status:approved This PR is fully reviewed, it will now soak for a while (at most 24h) before being merged. and removed status:waiting for author Reviews have shown that the author of this PR needs to change some things. labels Feb 20, 2026
@MonsterDruide1
Copy link
Copy Markdown
Owner Author

No, I tried searching for that, but wasn't able to find it. This PR makes no attempt of being complete, there is just too much still wrongly listed at the moment - I just worked on some stuff for a while, opened a few PRs and an issue in sead, bugged you to fix agl (open-ead/agl#23), and ... that's all for now.

@github-actions github-actions Bot added status:ready to merge This PR is fully reviewed and the usual slack time has expired, so it can now be merged at any time. and removed status:approved This PR is fully reviewed, it will now soak for a while (at most 24h) before being merged. labels Feb 21, 2026
@MonsterDruide1 MonsterDruide1 merged commit bf1e9d4 into master Feb 23, 2026
21 checks passed
@MonsterDruide1 MonsterDruide1 deleted the listsym-work branch February 23, 2026 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status:ready to merge This PR is fully reviewed and the usual slack time has expired, so it can now be merged at any time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants