data: List more already-implemented functions without symbols#911
Conversation
|
requires open-ead/sead#242 to match |
|
Mentioned dependencies are merged. Needs rebase |
a6e0694 to
87c6d33
Compare
|
Done, ready for review. |
german77
left a comment
There was a problem hiding this comment.
_GLOBAL__sub_I_seadBoundBox.cpp wasn't possible to be located? to be fair I wasn't able to locate it either.
@german77 made 1 comment.
Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on MonsterDruide1).
german77
left a comment
There was a problem hiding this comment.
@german77 reviewed 2 files and all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on MonsterDruide1).
|
No, I tried searching for that, but wasn't able to find it. This PR makes no attempt of being complete, there is just too much still wrongly listed at the moment - I just worked on some stuff for a while, opened a few PRs and an issue in |
Working through the output of
tools/listsymfor a while, I created a few PRs onseadto fix how code is generated over there - but some functions are actually correctly implemented, but just do not expose a symbol in SMO, so we can add those tofile_list.ymlmanually.This change is
Report for 1.0 (ae76c74 - 87c6d33)
📈 Matched code: 13.36% (+0.01%, +1180 bytes)
📈 1 improvement in an unmatched item
Scene/SceneObjFactorysceneObjCreator(int)