Conversation
pimlock
commented
Mar 20, 2026
johntmyers
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow running sandboxes that started with empty
network_policiesto accept their first live policy update. This removes a stale gateway-side mode distinction that no longer matches the proxy-backed runtime and adds regression coverage for the direct update path.Related Issue
Closes #491
Changes
network_policiesupdates on live sandboxesnetwork_policiesas proxy-backed deny-all instead of a separate immutable mode403to200Testing
mise run pre-commitpassescargo test -p openshell-server merge_chunk_into_policy_adds_first_network_rule_to_empty_policycargo test -p openshell-server sandbox_policy_backfill_on_update_when_no_baselinecargo test -p openshell-server validate_static_fields_allows_unchangedPYTHONPATH=python uv run pytest -o python_files='test_*.py' e2e/python/test_sandbox_policy.py -k 'live_policy_update_and_logs or live_policy_update_from_empty_network_policies' -n 1mise run pre-commitChecklist