feat(ovpntunnel): show all cert expirations #690
Conversation
gsanchietti
force-pushed
the
issue1481
branch
from
07c98b7 to
dfb9efd
Compare
gsanchietti
force-pushed
the
issue1481
branch
2 times, most recently
from
80dea89 to
d849dc5
Compare
There was a problem hiding this comment.
Pull request overview
This pull request enhances the OpenVPN tunnel feature to display expiration dates for all involved certificates (server, client, and CA) instead of just showing a single certificate expiration. The changes include updating the data model to support multiple certificate timestamps, refactoring the UI to display each certificate's expiration date separately, and updating translation keys to be more specific about which certificate is referenced.
Changes:
- Updated type definitions to replace single
cert_expiry_tsfield with acertificatesobject containing separate timestamps for server, client, and CA certificates - Modified certificate status logic to check appropriate certificates based on tunnel type (server or client)
- Enhanced tunnel info modal to display all three certificate expiration dates separately instead of showing status badges
- Updated translation keys to distinguish between server and client certificate messages
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/i18n/en.json | Updated certificate expiration messages to be more specific and added new translation keys for displaying individual certificate expiration dates |
| src/i18n/it.json | Updated existing certificate expiration messages (incomplete - missing new translation keys) |
| src/components/standalone/openvpn_tunnel/TunnelManager.vue | Changed type definitions to use certificates object with separate fields for server, client, and CA certificate timestamps |
| src/components/standalone/openvpn_tunnel/TunnelTable.vue | Updated getCertificateStatus function to accept certificates object and select appropriate certificate based on tunnel type |
| src/components/standalone/openvpn_tunnel/TunnelInfoModal.vue | Replaced certificate status badge display with separate labels showing each certificate's expiration date |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@gsanchietti I've opened a new pull request, #691, to work on those changes. Once the pull request is ready, I'll request review from you. |
gsanchietti
force-pushed
the
issue1481
branch
2 times, most recently
from
1bd555c to
c776e78
Compare
gsanchietti
force-pushed
the
issue1481
branch
from
c776e78 to
016fa6f
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Display the expiration of all involved certificates: - client - server - CA
gsanchietti
force-pushed
the
issue1481
branch
from
016fa6f to
5d8aeb8
Compare
Display the expiration of all involved certificates:
API changes: NethServer/nethsecurity#1502
Client expiration:
Server expiration:
Server cert details:
Client cert details:
