Skip to content

Fix Windows build#2007

Merged
jordimas merged 3 commits intoOpenNMT:masterfrom
sssshhhhhh:windows
Feb 4, 2026
Merged

Fix Windows build#2007
jordimas merged 3 commits intoOpenNMT:masterfrom
sssshhhhhh:windows

Conversation

@sssshhhhhh
Copy link
Contributor

@sssshhhhhh sssshhhhhh commented Feb 3, 2026

Fix #2006
Remove some compatability for python 3.8/3.7
Add windows ci

@jordimas jordimas changed the title Fix windows Fix Windows build Feb 3, 2026
@jordimas
Copy link
Collaborator

jordimas commented Feb 4, 2026

Thanks for quick fix @sssshhhhhh

@jordimas jordimas merged commit a498aae into OpenNMT:master Feb 4, 2026
40 of 42 checks passed
@sssshhhhhh sssshhhhhh deleted the windows branch February 13, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add_dll_directory does not always find the correct ROCm binary on some systems

2 participants