Skip to content

Fix Windows build #2007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jordimas merged 3 commits into from
Feb 4, 2026
Merged

Fix Windows build #2007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
370e470
Fix windows
sssshhhhhh Feb 3, 2026
5bd8a4b
Update __init__.py
sssshhhhhh Feb 3, 2026
30ffb23
Update __init__.py
sssshhhhhh Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,10 @@ jobs:
artifact_pattern: python-wheels-Linux-aarch64
wheel_pattern: "*cp310*manylinux*_aarch64.whl"

- os: windows-2022
artifact_pattern: python-wheels-Windows-auto64
wheel_pattern: "*cp310*win*amd64.whl"

- os: macos-15
artifact_pattern: python-wheels-macOS-arm64
wheel_pattern: "*cp310*macosx*arm64.whl"
Expand Down
23 changes: 8 additions & 15 deletions python/ctranslate2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,17 @@
import glob
import os

from importlib.resources import files

module_name = sys.modules[__name__].__name__
package_dir = str(files(module_name))

# Adressing python 3.9 < version
try:
from importlib.resources import files

# Fixed the pkg_resources depreciation
package_dir = str(files(module_name))
except ImportError:
import pkg_resources

package_dir = pkg_resources.resource_filename(module_name, "")

add_dll_directory = getattr(os, "add_dll_directory", None)
if add_dll_directory is not None:
add_dll_directory(package_dir)
add_dll_directory(f"{package_dir}/../_rocm_sdk_core/bin")
add_dll_directory(f"{package_dir}/../_rocm_sdk_libraries_custom/bin")
os.add_dll_directory(package_dir)
os.add_dll_directory(f"{package_dir}/../_rocm_sdk_core/bin")
os.add_dll_directory(f"{package_dir}/../_rocm_sdk_libraries_custom/bin")
except (FileNotFoundError, OSError):
pass

for library in glob.glob(os.path.join(package_dir, "*.dll")):
ctypes.CDLL(library)
Expand Down