Self-review fixes: 4 issues caught by deep audit (snowflake space, README cadence regression, 2026 wording, detect_copilot false positive)#77
Merged
Conversation
After PRs #59-#76 landed, did a deep self-review across content, distribution, structure, and docs coherence (4 parallel audit agents). Most of the repo is clean. Four real findings, all P2/P3: P2: finops-snowflake.md line 230 had a missing space after a period ("warehouse.This leads") - same artefact pattern as previous Codex follow-up rounds. Fixed. P2: README.md line 419 had "bi-monthly refresh" - regression. We standardised on "twice-monthly" in PR #62 and verified clean in multiple subsequent passes; this occurrence was inside a Contributing paragraph that was rewritten in PR #68 and apparently re-introduced the older wording. Fixed back to "twice-monthly refresh". P2: SKILL.md line 79 and POWER.md line 235 said "FinOps Foundation (2025 wording)" for the six principles. After the FCP 2026 migration in PR #71, this year reference is dated. Updated to "(2026 framework)". The principles themselves (six bullets) are unchanged by the 2026 update. P3: install.sh detect_copilot() heuristic was `command -v code >/dev/null 2>&1 || [[ -d ".github" ]]`. The .github directory exists in essentially every GitHub-hosted repo (issue templates, workflows, dependabot config), so the heuristic over-detected Copilot in 90%+ of project setups. Removed the .github bare-directory check; replaced with a more specific `[[ -f ".github/copilot-instructions.md" ]]` check (which is the exact file the Copilot install path writes - so detection only fires when (a) VS Code CLI is installed OR (b) the repo already has a Copilot custom-instructions file). Also added a comment explaining the over-detection rationale so the weakening is auditable. Verified: bash install.sh --dry-run --tool all --dest /tmp passes, all 11 tools report intended paths, syntax check clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After PRs #59-#76 landed, ran a deep self-review with 4 parallel audit agents (content / distribution / docs coherence / structure). Most of the repo is clean. Four real findings, all P2/P3:
finops-snowflake.md:230- "warehouse.This leads" missing space (same pattern as previous Codex follow-ups)README.md:419- "bi-monthly refresh" regression. We standardised on "twice-monthly" in PR Codex follow-up #3: grouped routing, GCP CUD contradiction, AWS Config pattern, cadence wording #62; this occurrence was inside the Contributing paragraph rewritten in PR README: install table + tool icons + restructured Design principles & Contributing + INSTALLATION sync #68 and apparently re-introduced the older wordingSKILL.md:79+POWER.md:235- "FinOps Foundation (2025 wording)" updated to "(2026 framework)" to align with the FCP 2026 migration in PR PR B: migrate to FinOps Framework 2026 taxonomy (frontmatters + script + reference + routing) #71install.sh detect_copilot()- the previous heuristiccommand -v code || [[ -d ".github" ]]over-detected Copilot in essentially every GitHub-hosted repo. Replaced the.githubbare-directory check with[[ -f ".github/copilot-instructions.md" ]]so the heuristic only fires on real signals (VS Code CLI installed OR repo already has a Copilot custom-instructions file). Audit comment added.What the audit explicitly found clean
v1.20.0matches plugin.json)--dry-run --tool allcleanlyTest plan
grep "warehouse\.[A-Z]" cloud-finops/references/finops-snowflake.mdreturns nothinggrep "bi-monthly" README.mdreturns nothinggrep "2025 wording" cloud-finops/SKILL.md cloud-finops/POWER.mdreturns nothingbash -n install.shsucceedsbash install.sh --dry-run --tool all --dest /tmp/auditpasses for all 11 tools🤖 Generated with Claude Code