fix: segfault in Topic Re-Publisher on Jazzy (uninitialized callbacks_ in GenericPublisher)#113
Open
facontidavide wants to merge 3 commits intomainfrom
Open
fix: segfault in Topic Re-Publisher on Jazzy (uninitialized callbacks_ in GenericPublisher)#113facontidavide wants to merge 3 commits intomainfrom
facontidavide wants to merge 3 commits intomainfrom
Conversation
…cks_ member
The callbacks_ member was passed to the rclcpp::PublisherBase base class
constructor before it was initialized (C++ UB), causing a segfault inside
rclcpp::JumpHandler::JumpHandler on Jazzy. Replace with a default-constructed
temporary rclcpp::PublisherEventCallbacks{} and remove the now-unused member.
Fixes #112
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callbacks_(a member ofGenericPublisher) was passed to therclcpp::PublisherBasebase class constructor before it was initialized — C++ undefined behaviorrclcpp::PublisherBasecallsrclcpp::JumpHandler::JumpHandlerduring construction while processing the callbacks, which dereferences the uninitialized object and causes a segfaultcallbacks_with a default-constructed temporaryrclcpp::PublisherEventCallbacks{}and remove the now-unused memberTest plan
Closes #112
🤖 Generated with Claude Code