fix: segfault in Topic Re-Publisher on Jazzy (uninitialized callbacks_ in GenericPublisher)

CHANGELOG.rst

@@ -2,6 +2,25 @@
 Changelog for package plotjuggler_ros
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 
+2.3.2 (2025-12-21)
+------------------
+* fix CI
+* fail to compile
+* fix
+* add pre-commit step
+* new formatting rules
+* add formatting consistent with plotjuggler App
+* Fix O(n^2) complexity in ROS2 topic selection dialog. (`#106 <https://github.com/PlotJuggler/plotjuggler-ros-plugins/issues/106>`_)
+* Depend on ros_environment for Humble detection (`#107 <https://github.com/PlotJuggler/plotjuggler-ros-plugins/issues/107>`_)
+  PR `#98 <https://github.com/PlotJuggler/plotjuggler-ros-plugins/issues/98>`_ mistakenly removed ros_environment from package.xml. This broke
+  Humble detection, which had to be worked around in 9b03f97 ("try
+  detecting Humble in the build farm", 2025-06-10).
+  This PR adds ros_environment dependency back and removes the Humble
+  detection workaround.
+  This also helps with building the package using the Nix package
+  manager.
+* Contributors: Davide Faconti, Michal Sojka, ksuszka
+
 2.2.0 (2025-05-21)
 ------------------
 * jazzy+

package.xml

@@ -1,7 +1,7 @@
 <?xml version="1.0"?>
 <package format="3">
     <name>plotjuggler_ros</name>
-    <version>2.3.1</version>
+    <version>2.3.2</version>
     <description>PlotJuggler plugin for ROS</description>
 
     <maintainer email="davide.faconti@gmail.com">Davide Faconti</maintainer>

src/TopicPublisherROS2/generic_publisher.h

@@ -28,7 +28,8 @@ class GenericPublisher : public rclcpp::PublisherBase
 #ifdef ROS_HUMBLE
     : rclcpp::PublisherBase(node_base, topic_name, type_support, rcl_publisher_get_default_options())
 #else
-    : rclcpp::PublisherBase(node_base, topic_name, type_support, rcl_publisher_get_default_options(), callbacks_, true)
+    : rclcpp::PublisherBase(node_base, topic_name, type_support, rcl_publisher_get_default_options(),
+                            rclcpp::PublisherEventCallbacks{}, true)
 #endif
   {
   }
@@ -53,10 +54,6 @@ class GenericPublisher : public rclcpp::PublisherBase
 
     return std::make_shared<GenericPublisher>(node.get_node_base_interface().get(), topic_name, *type_support);
   }
-
-#ifndef ROS_HUMBLE
-  rclcpp::PublisherEventCallbacks callbacks_;
-#endif
 };
 
 #endif  // GENERIC_PUBLISHER_H

src/TopicPublisherROS2/publisher_ros2.cpp

@@ -14,6 +14,7 @@
 #include <QRadioButton>
 #include <unordered_map>
 #include <QMessageBox>
+#include <algorithm>
 #include <tf2_ros/qos.hpp>
 #include <rosbag2_cpp/types.hpp>
 #include <rmw/rmw.h>
@@ -153,7 +154,7 @@ void TopicPublisherROS2::filterDialog()
 
   std::map<std::string, QCheckBox*> checkbox;
 
-  for (const TopicInfo& info : _topics_info)
+  for (const TopicInfo& info : sorted_topics)
   {
     const std::string topic_name = info.topic_name;
     auto cb = new QCheckBox(dialog);