You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thank you very much for contributing this to PyLabRobot!
A couple of points to get this merged:
PyLabRobot Resources are organised & named first by manufacturer. This avoids confusion about vendors and vendor-specific catalogue numbers masking the manufacturer's catalogue numbers.
Applied Biosystems is not a company (anymore) but a brand owned by Thermo Fisher Scientific (see organisational structure in the PLR docs and screenshot below).
That is the reason why PLR does not have and shouldn't have an "Applied Biosystems" folder
-> please remove the folder and move the definition into /pylabrobot/resources/thermo_fisher
The naming convention should be <manufacturer (lowercase, PLR-convention)>_<brand (PLR-convention)_<throughput>_<resource_type>_<miscellaneous identifier (a bit of a wildcard)
-> I would suggest renaming to thermo_AB_96_plateadapter_MicroAmp?
Please ensure that the first line of the docstrings specifies the catalogue number; example:
(this is important for parsers and docstring consistency)
Note: You may notice some inconsistencies in naming conventions in the existing codebase - this is a known legacy issue that is actively being cleaned up.
Please follow the conventions outlined above rather than using existing definitions as a reference.
@jemancuso, please feel free to ignore point 3 - it is a bit nitpicky 😂
The reason I do this is to enable classic parsers based on first line of docstring regular expression identification, but it's not essential
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Applied Biosystems™ MicroAmp™ Splash-Free 96-Well Base, Item No.: 4312063
https://www.fishersci.com/shop/products/applied-biosystems-microamp-splash-free-96-well-base/4312063