Fix CI issues found in upstream Zebra ZSA PR#132
Conversation
ci: fix issues found in upstream Zebra PR
dmidem
force-pushed
the
sync-zcash-v4.2.0-merge
branch
from
bb1b718 to
a90946a
Compare
|
|
||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2 |
There was a problem hiding this comment.
I ultimately decided to literally stick to the upstream approach to ensure our CI works the same as theirs:
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/lint.yml#L63
Not sure why they explicitly use this commit, it needs to be checked.
| for attempt in 1 2 3; do | ||
| echo "network-sensitive tests attempt ${attempt}" | ||
|
|
||
| timeout --preserve-status 45m bash -c ' | ||
| set -euo pipefail | ||
| cargo test -p zebra-network --lib --verbose --locked -- --test-threads=1 | ||
| cargo test -p zebrad --test acceptance --verbose --locked -- --test-threads=1 | ||
| ' && exit 0 | ||
|
|
||
| status=$? | ||
| echo "network-sensitive tests attempt ${attempt} failed with status ${status}" |
There was a problem hiding this comment.
This code reruns all tests in zebra-network --lib and zebrad --test acceptance, not just network-gated ones.
If a change break one of these test, unrelated to bad network, we will rerun 3x45 min before job fails. In addition to 1H run of step 1.
There was a problem hiding this comment.
Not blocking for this PR after solving https://github.com/QED-it/zebra/pull/132/changes#r3355680589
| cargo test -p zebra-network --lib --verbose --locked -- --test-threads=1 | ||
| cargo test -p zebrad --test acceptance --verbose --locked -- --test-threads=1 |
There was a problem hiding this comment.
Let's split each cargo test .. into each own retry loop. If the second fails we should not run the first one again.
There was a problem hiding this comment.
done in https://github.com/QED-it/zebra/pull/139/changes. (can just take the commit)
| branches: | ||
| - main | ||
| - v4.2.0-dev |
…ptance tests in ci-basic.yml
2 participants
This fixes CI issues observed on the upstream Zebra PR in our fork’s Basic checks workflow.
Changes:
actions/checkoutand disabling persisted credentials;