Use ExpectedTranscriptError in Orchard ZSA workflow block tests#133
Open
dmidem wants to merge 6 commits into
Open
Use ExpectedTranscriptError in Orchard ZSA workflow block tests#133dmidem wants to merge 6 commits into
dmidem wants to merge 6 commits into
Conversation
…r instead of the is_valid flag
dmidem
force-pushed
the
sync-zcash-v4.2.0-merge
branch
from
bb1b718 to
a90946a
Compare
PaulLaux
reviewed
Jun 4, 2026
| fi | ||
|
|
||
| sleep 30 | ||
| done |
There was a problem hiding this comment.
These changes does not seem to be related to PR title. should move it to a separate PR / rollback ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the
is_valid: boolfield inOrchardWorkflowBlockwith an explicitResult<(), ExpectedTranscriptError>as discussed in issue #116.The original test gap was that
is_valid: falseonly checked that block 5 failed, but did not check why it failed. Ideally, this test should assert that block 5 is rejected specifically because it tries to issue more assets after issuance was finalized.I tried to make the workflow vector check that exact error, but the current transcript test API only supports
ExpectedTranscriptError::AnyandExpectedTranscriptError::Exact(...). For this rejection path, there is no specific error currently exposed through the transcript checker that can be matched here, so block 5 still usesErr(ExpectedTranscriptError::Any).So this PR does not fully add the semantic “post-finalization issuance” check yet, but it does remove the boolean validity flag and changes the vector format to use the typed transcript expected-result API. This makes the test data clearer and leaves the code ready for a stricter expected error once the transcript checker can expose one.