qvm-template-upgrade: add CLI skeleton and orchestration flow#213
Open
nihalxkumar wants to merge 1 commit into
Open
qvm-template-upgrade: add CLI skeleton and orchestration flow#213nihalxkumar wants to merge 1 commit into
nihalxkumar wants to merge 1 commit into
Conversation
ben-grande
suggested changes
May 25, 2026
ben-grande
left a comment
ben-grande
left a comment
Contributor
There was a problem hiding this comment.
Yay, started. As I've done a review now, I will receive a notification every time you commit. Let me know when you need another look or have doubts by mentioning me.
ben-grande
reviewed
May 27, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 71.72% 77.29% +5.56%
==========================================
Files 12 14 +2
Lines 1337 1665 +328
==========================================
+ Hits 959 1287 +328
Misses 378 378 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
PipelineRetryFailed |
Author
|
It's showing a successful run 
|
Contributor
|
Some tests are not enabled on this repo, such as mypy, black and pylint. See this as an example: https://github.com/QubesOS/qubes-core-admin/blob/main/.gitlab-ci.yml. Can you create a separate PR to enable those checks? |
Author
|
Sure, will do |
ben-grande
suggested changes
Jun 7, 2026
Author
|
We can squash here if it's looks fine. Will also have to rebase as this is 24 commits behind. |
Contributor
|
Looks fine to squash. |
Add qvm-template-upgrade as an initial safe upgrade workflow for TemplateVMs and StandaloneVMs. The command validates the source qube, derives the next distro-version clone name, clones the source, updates template metadata, and cleans up failed clones unless explicitly asked to keep them. The version-upgrade agent hook remains a stub for now, so the command can land the orchestration, rollback behavior, and tests without pretending to perform in-VM distro upgrades yet. Fixes: QubesOS/qubes-issues#8605
nihalxkumar
force-pushed
the
qvm-template-upgrade
branch
from
71dee9e to
6c3d431
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for the GSoC 2026 project: Automate Template Version Upgrade
introducing the
qvm-template-upgradedom0 command-line utility, which provides the orchestration layer for in-place template version upgrades.TLDR of what this PR does at the moment:
--keep-on-failureis passed), leaving the original template untouched.related to QubesOS/qubes-issues#8605.