feat(ux): adopt action-verb canon on InlineDecisionButtons (ops surfaces)#568
Closed
Victor "David" Medina (Victor-David-Medina) wants to merge 1 commit into
Closed
feat(ux): adopt action-verb canon on InlineDecisionButtons (ops surfaces)#568Victor "David" Medina (Victor-David-Medina) wants to merge 1 commit into
Victor "David" Medina (Victor-David-Medina) wants to merge 1 commit into
Conversation
…urfaces) Completes the verb canon from #564 across the operations surfaces (Slot Rescue / Review Lift / Estimate Recovery). The inline Snooze/Dismiss icon buttons carried off-canon hover+aria labels ('Snooze' / 'Dismiss') while Focus uses 'Not now' / 'Hide'. A user who learns the verbs in Focus now sees the same words everywhere. - import ACTION_VERBS; Snooze icon -> aria/title 'Not now' (skipped, Clock icon already correct) - Dismiss icon -> aria/title 'Hide' (dismissed, X icon already correct) - backend action keys (snooze/dismiss) + DECIDE_STATUS unchanged; icons unchanged - test: the dismiss assertion -> /Hide.*client/ Structurally verified (imports + canon usage confirmed); identical pattern to the merged-green #564. CI is the test gate. Built in an isolated worktree. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Someone is attempting to deploy this pull request to the davidmedina-8534's projects Team on Vercel. No GitHub account was found matching the commit author email address. To deploy this pull request, the commit author's email address needs to be associated with a GitHub account. Learn more about how to change the commit author information. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🛡️ Cascade Quality Score: 100/100
Threshold: 85/100 | Result: PASS ✅ |
Collaborator
Author
|
Superseded by clean-author replacement. The diff is valid, but this original branch tripped Vercel's unlinked author-email gate. |
Victor "David" Medina (Victor-David-Medina)
deleted the
claude/inline-verb-canon
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes the verb canon (#564) across the operations surfaces (Slot Rescue / Review Lift / Estimate Recovery). The inline Snooze/Dismiss icon buttons carried off-canon hover+aria labels ("Snooze"/"Dismiss") while Focus uses "Not now"/"Hide". Now a user who learns the verbs in Focus sees the same words everywhere.
Snoozeicon → aria/title "Not now" (ACTION_VERBS.skipped; Clock icon already matched)Dismissicon → aria/title "Hide" (ACTION_VERBS.dismissed; X icon already matched)DECIDE_STATUSunchanged; icons unchanged/Hide.*client/Identical pattern to the merged-green #564. Built in an isolated worktree (no shared-repo race).