refactor(pdf-worker): remove unnecessary ReactElement type annotations from components

[tassoevan]

⚠️ This is part 10/23 of #40796. PR for refactor/prepare-types-for-react-19-9 must be merged first.

---

Proposed changes (including videos or screenshots)

As a first step towards upgrading to React 19, it handles types from @types/react looking forward the next major.

Issue(s)

Task: ARCH-2170

Steps to test or reproduce

Further comments

No runtime change is expected from it.

Summary by CodeRabbit

• Refactor
  • Improved code consistency in PDF chat transcript components through type annotation refinements.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d156e060-d679-43a4-8908-cf8d7c23cd23

📥 Commits

Reviewing files that changed from the base of the PR and between 027d784 and 868496a.

📒 Files selected for processing (4)

• ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx

📜 Recent review details

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: 📦 Build Packages
• GitHub Check: cubic · AI code reviewer
• GitHub Check: Hacktron Security Check
• GitHub Check: CodeQL-Build
• GitHub Check: CodeQL-Build

🧰 Additional context used

📓 Path-based instructions (1)

**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests
Avoid code comments in the implementation

Files:

• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx

🧠 Learnings (2)

📚 Learning: 2026-03-27T14:52:56.865Z

Learnt from: dougfabris
Repo: RocketChat/Rocket.Chat PR: 39892
File: apps/meteor/client/views/room/contextualBar/Threads/Thread.tsx:150-155
Timestamp: 2026-03-27T14:52:56.865Z
Learning: In Rocket.Chat, there are two different `ModalBackdrop` components with different prop APIs. During review, confirm the import source: (1) `rocket.chat/fuselage` `ModalBackdrop` uses `ModalBackdropProps` based on `BoxProps` (so it supports `onClick` and other Box/DOM props) and does not have an `onDismiss` prop; (2) `rocket.chat/ui-client` `ModalBackdrop` uses a narrower props interface like `{ children?: ReactNode; onDismiss?: () => void }` and handles Escape keypress and outside mouse-up, and it does not forward arbitrary DOM props such as `onClick`. Flag mismatched props (e.g., `onDismiss` passed to the fuselage component or `onClick` passed to the ui-client component) and ensure the usage matches the correct component being imported.

Applied to files:

• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx

📚 Learning: 2026-05-06T12:21:44.083Z

Learnt from: juliajforesti
Repo: RocketChat/Rocket.Chat PR: 40256
File: apps/meteor/client/components/CreateDiscussion/CreateDiscussion.tsx:121-149
Timestamp: 2026-05-06T12:21:44.083Z
Learning: Field wrappers in rocket.chat/fuselage-forms (Field, FieldLabel, FieldRow, FieldError, FieldHint) auto-create htmlFor/id associations, aria-describedby, and role="alert" for errors. Do not manually set htmlFor, id, aria-describedby, or role attributes when using these wrappers. This automatic wiring does not apply to plain rocket.chat/fuselage components, which require explicit ID wiring per the accessibility docs. In code reviews, prefer using fuselage-forms wrappers for form fields and verify there is no unnecessary manual ID/aria wiring in files that use these wrappers. If a component uses plain fuselage components, ensure proper id wiring as per docs.

Applied to files:

• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx
• ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx

🔇 Additional comments (4)

ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx (1)

9-9: LGTM!

ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx (1)

10-10: LGTM!

ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx (1)

13-13: LGTM!

ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx (1)

54-54: LGTM!

---

Walkthrough

Four React components in the ChatTranscript template are refactored to remove explicit ReactElement return type annotations and rely on inferred types. The Quotes component's accumulator type is widened from JSX.Element | null to ReactNode to align with the simplified leaf component typing.

Changes

React Type Annotation Cleanup

Layer / File(s)	Summary
Remove explicit ReactElement from block and element components ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx, ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx, ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx	BigEmojiBlock, CodeBlock, and LinkSpan components drop explicit ReactElement return type annotations and remove the corresponding import. Component logic and prop typing remain unchanged.
Widen Quotes accumulator type to ReactNode ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx	The quotes.reduceRight accumulator type changes from JSX.Element | null to ReactNode to reflect the broader return types of the refactored leaf components.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

• RocketChat/Rocket.Chat#40806: Refactors React component typings by removing explicit ReactElement return type annotations with no runtime logic changes.
• RocketChat/Rocket.Chat#40807: Performs the same TypeScript refactor of removing explicit ReactElement return type annotations from React components.
• RocketChat/Rocket.Chat#40805: Applies the same TypeScript refactor pattern of removing explicit ReactElement return annotations and widening to ReactNode in React components.

Suggested labels

type: chore

Suggested reviewers

• juliajforesti
• ggazzo

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The pull request title accurately describes the main change: removing unnecessary ReactElement type annotations from components in the pdf-worker package, which aligns with all file modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (2)

• REACT-19: Request failed with status code 401
• ARCH-2170: Request failed with status code 401

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[dionisio-bot]

Looks like this PR is ready to merge! 🎉
If you have any trouble, please check the PR guidelines

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.15%. Comparing base (027d784) to head (868496a).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #40812      +/-   ##
===========================================
+ Coverage    70.13%   70.15%   +0.02%     
===========================================
  Files         3340     3340              
  Lines       123638   123638              
  Branches     22041    22006      -35     
===========================================
+ Hits         86708    86742      +34     
+ Misses       33586    33559      -27     
+ Partials      3344     3337       -7     

Flag	Coverage Δ
e2e	59.38% <ø> (+0.08%)	⬆️
e2e-api	46.27% <ø> (+0.02%)	⬆️
unit	70.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 868496a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[cubic-dev-ai]

No issues found across 4 files

_{Re-trigger cubic}