Skip to content

refactor(pdf-worker): remove unnecessary ReactElement type annotations from components #40812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tassoevan merged 1 commit into from
Jun 9, 2026
Merged

refactor(pdf-worker): remove unnecessary ReactElement type annotations from components #40812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ee/packages/pdf-worker/src/templates/ChatTranscript/components/Quotes.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type QuotesProps = {
};

export const Quotes = ({ quotes }: QuotesProps) =>
quotes.reduceRight<JSX.Element | null>(
quotes.reduceRight<ReactNode>(
(lastQuote, quote, index) => (
<Quote quote={quote} index={index}>
{lastQuote}
Expand Down
3 changes: 1 addition & 2 deletions ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/BigEmojiBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
import { Text } from '@react-pdf/renderer';
import type * as MessageParser from '@rocket.chat/message-parser';
import emojione from 'emoji-toolkit';
import type { ReactElement } from 'react';

type BigEmojiBlockProps = {
emoji: MessageParser.Emoji[];
};

const BigEmojiBlock = ({ emoji }: BigEmojiBlockProps): ReactElement => (
const BigEmojiBlock = ({ emoji }: BigEmojiBlockProps) => (
<Text>
{emoji.map((emoji, index) => (
<Text key={index}>{emoji.value ? `:${emoji.value?.value}:` : emojione.toShort(emoji.unicode)}</Text>
Expand Down
3 changes: 1 addition & 2 deletions ee/packages/pdf-worker/src/templates/ChatTranscript/markup/blocks/CodeBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
import { Text, View } from '@react-pdf/renderer';
import type * as MessageParser from '@rocket.chat/message-parser';
import type { ReactElement } from 'react';

import { codeStyles } from '../elements/CodeSpan';

type CodeBlockProps = {
lines: MessageParser.CodeLine[];
};

const CodeBlock = ({ lines }: CodeBlockProps): ReactElement => (
const CodeBlock = ({ lines }: CodeBlockProps) => (
<View style={{ ...codeStyles.wrapper, padding: 8 }} wrap>
{lines.map((line, index) => (
<Text key={index} style={codeStyles.code}>
Expand Down
3 changes: 1 addition & 2 deletions ee/packages/pdf-worker/src/templates/ChatTranscript/markup/elements/LinkSpan.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { View, Text } from '@react-pdf/renderer';
import type * as MessageParser from '@rocket.chat/message-parser';
import type { ReactElement } from 'react';
import { useMemo } from 'react';

import BoldSpan from './BoldSpan';
Expand All @@ -11,7 +10,7 @@ type LinkSpanProps = {
label: MessageParser.Markup | MessageParser.Markup[];
};

const LinkSpan = ({ label }: LinkSpanProps): ReactElement => {
const LinkSpan = ({ label }: LinkSpanProps) => {
const children = useMemo(() => {
const labelArray = Array.isArray(label) ? label : [label];

Expand Down
Loading