Refactor: centralize column constants and eliminate duplicate segment assignment#1
Draft
Refactor: centralize column constants and eliminate duplicate segment assignment#1
Conversation
…signment Co-authored-by: Sasisundar2211 <139478565+Sasisundar2211@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code for better maintainability
Refactor: centralize column constants and eliminate duplicate segment assignment
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two classes of code duplication existed across the
src/modules: column name strings were hardcoded independently in bothfeature_engineering.pyanddata_preprocessing.py, anddf['segment'] = labelswas assigned in bothgenerate_model.pyandprofiling.py.Changes
New
src/constants.py— single source of truth for all column names (NUMERICAL_COLS,CATEGORICAL_COLS, and individual constants likeENGAGEMENT_SCORE_COL,CTR_COL, etc.)src/data_preprocessing.py— replaces inline column lists with imports fromconstants.pysrc/feature_engineering.py— replaces hardcoded column string literals with named constants fromconstants.pygenerate_model.py— removes duplicatedf['segment'] = labelsassignment; delegates toprofile_segments(df, labels)which already performs it✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.