Skip to content

chore: pass short lang because svelte-i18n uses two letter language keys#3264

Merged
stevekaplan123 merged 2 commits intomasterfrom
feature/sc-43295/extract-all-hard-coded-strings-to-language
May 11, 2026
Merged

chore: pass short lang because svelte-i18n uses two letter language keys#3264
stevekaplan123 merged 2 commits intomasterfrom
feature/sc-43295/extract-all-hard-coded-strings-to-language

Conversation

@stevekaplan123
Copy link
Copy Markdown
Contributor

Description

We should be passing 'en' or 'he' rather than 'english' or 'hebrew' because svelte-i18n uses two letter language keys

@gitvelocity-reviewer
Copy link
Copy Markdown

📊 Code Quality Score: 1/100

Base Score 10 × ESF 0.1 (Nano: 2 effective lines, 1 file) = 1.0

Category Score Factors
🔭 Scope 2/20 Single file, single line change, no new APIs or subsystems touched
🏗️ Architecture 1/20 No architectural change; minor call-site substitution within existing render method
⚙️ Implementation 2/20 Trivial one-line substitution replacing a prop reference with a utility method call
⚠️ Risk 3/20 Low risk overall; potential concern if _getShortInterfaceLang() returns unexpected format or null; affects chatbot behavior
✅ Quality 2/15 No tests added; change is too small to require them; no documentation needed
🔒 Perf / Security 0/5 No performance or security considerations addressed

Scored by GitVelocity · How are scores calculated?

@stevekaplan123 stevekaplan123 marked this pull request as draft May 6, 2026 07:11
Copy link
Copy Markdown
Contributor

@YishaiGlasner YishaiGlasner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we submit the full language, i guess it means svelte uses it, so that seems as a breaking chage. did you check we don't assume somewhere we have the whole string?

@stevekaplan123
Copy link
Copy Markdown
Contributor Author

if we submit the full language, i guess it means svelte uses it, so that seems as a breaking chage. did you check we don't assume somewhere we have the whole string?

That's a fair point, but I've made the relevant changes in the ai-chatbot in a separate PR.

@stevekaplan123 stevekaplan123 added this pull request to the merge queue May 11, 2026
Merged via the queue into master with commit d5c8c58 May 11, 2026
30 of 31 checks passed
@gitvelocity-reviewer
Copy link
Copy Markdown

📊 Code Quality Score: 1/100

10 × 0.1 (Nano ESF) = 1

Category Score Factors
🔭 Scope 2/20 Single file, single line change, localized to chatbot component prop
🏗️ Architecture 1/20 No architectural changes; simple prop-to-method substitution
⚙️ Implementation 3/20 Trivial substitution using correct utility method; no algorithmic complexity
⚠️ Risk 3/20 Low risk, easily reversible, localized to chatbot feature only
✅ Quality 1/15 No tests or documentation added; change is trivial and self-explanatory
🔒 Perf / Security 0/5 No performance or security considerations addressed

Scored by GitVelocity · How are scores calculated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants