feat: add error message normalization utility #1694

morgan-wowk · 2026-01-26T20:49:54Z

Description

Added error message normalization functionality to standardize error messages by extracting dynamic values (UUIDs, IDs, hashes, etc.) and replacing them with placeholders. This helps group similar errors that differ only in their dynamic values.

The implementation includes:

A normalizeErrorMessage function that extracts various types of dynamic values
Comprehensive test coverage for different error message patterns
Support for extracting UUIDs, numeric IDs, alphanumeric IDs, query parameters, hash values, and quoted strings
Message truncation for very long error messages

Type of Change

New feature
Improvement

Checklist

I have tested this does not break current pipelines / runs functionality
I have tested the changes on staging

Test Instructions

Run the test suite with npm test src/services/errorManagement/normalizeErrorMessage.test.ts to verify the functionality works as expected.

morgan-wowk · 2026-01-26T20:50:10Z

feat: add Bugsnag error reporting service #1695
feat: add error message normalization utility #1694 👈 (View in Graphite)
master

This stack of pull requests is managed by Graphite. Learn more about stacking.

Mbeaulne · 2026-01-26T21:17:05Z

src/services/errorManagement/normalizeErrorMessage.ts

+
+  // Extract UUIDs
+  normalized = normalized.replace(
+    /\/([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})(\/|$|\)|\s)/gi,


can we abstract these into a variable so I know what the regex does? I know there is a comment, but I would rather have a named constant or something

Absolutely. Good idea

Implemented

Mbeaulne · 2026-01-26T21:18:13Z

src/services/errorManagement/normalizeErrorMessage.ts

+  extractedValues: Record<string, string>;
+} {
+  const extractedValues: Record<string, string> = {};
+  let counter = 1;


can we name this counter variable something a little more obvious? What is it counting, errors? errorCount or something.

extractedValueIndex would be more appropriate

It is the index of the value extracted from the original message

So if abcd is replaced first, extractedValueIndex is 1. and it becomes var1 in the normalized output. Incrementing from there for every match and replacement.

Mbeaulne · 2026-01-26T21:29:54Z

src/services/errorManagement/normalizeErrorMessage.ts

+  normalized = normalized.replace(
+    /\/([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})(\/|$|\)|\s)/gi,
+    (_match, uuid, after) => {
+      const placeholder = `{var${counter}}`;
+      extractedValues[placeholder] = uuid;
+      counter++;
+      return `/${placeholder}${after}`;
+    },
+  );


The inline regex chains are hard to follow. Consider something like:

const NORMALIZATION_PATTERNS = { uuid: { pattern: /\/([0-9a-f]{8}-[0-9a-f]{4}-...)/gi, replacer: (_, uuid, after, placeholder) => `/${placeholder}${after}`, }, numericPathId: { pattern: /\/(\d+)(\/|$|\)|\s)/g, replacer: (_, num, after, placeholder) => `/${placeholder}${after}`, }, // ... etc }; // Then just loop: for (const { pattern, replacer } of Object.values(NORMALIZATION_PATTERNS)) { normalized = normalized.replace(pattern, (...args) => { const placeholder = `{var${counter++}}`; return replacer(...args, placeholder); }); }

Why:

Readable - pattern names explain intent without reading the regex

Testable - can unit test individual patterns in isolation

Maintainable - adding/modifying patterns is just editing the object, not hunting through a chain of .replace() calls

Not blocking, but would make future debugging much easier.

I dig it. I'll be adding something like this

Thanks for the suggestion

Implemented

Mbeaulne · 2026-01-26T21:32:47Z

src/services/errorManagement/normalizeErrorMessage.ts

+  if (normalized.length > 200) {
+    normalized = normalized.substring(0, 197) + "...";
+  }


lets replace some of these magic numbers:

const MAX_MESSAGE_LENGTH = 200; const MAX_MESSAGE_TRUNCATED_LENGTH = 197

There are a few more above as well

Implemented

Mbeaulne · 2026-01-26T21:33:46Z

src/services/errorManagement/normalizeErrorMessage.ts

+  // Extract quoted strings
+  normalized = normalized.replace(/"([^"]+)"/g, (_match, content) => {
+    const placeholder = `{var${counter}}`;
+    extractedValues[placeholder] = content;
+    counter++;
+    return placeholder;
+  });
+
+  normalized = normalized.replace(/'([^']+)'/g, (_match, content) => {
+    const placeholder = `{var${counter}}`;
+    extractedValues[placeholder] = content;
+    counter++;
+    return placeholder;
+  });


Can these be replaces with one? /["']([^"']+)["']/g

Current approach (two separate patterns):

/"([^"]+)"/g - matches "hello" ✓

/'([^']+)'/g - matches 'world' ✓

Won't match "mixed' or 'mixed" ✗

Suggested pattern /["']([^"']+)["']/g:

Matches "hello" ✓

Matches 'world' ✓

Also matches "mixed' and 'mixed" ✓ (probably not desirable)

For error message normalization, we likely want to extract properly quoted strings only, not strings with mismatched quotes. Mismatched quotes are often syntax errors or literal parts of the error message itself, not dynamic values we want to normalize.

Claude's recommendation: Keep the two separate patterns for correctness. The slight code duplication is worth ensuring we only extract properly quoted strings.

Let me know if you have strong feelings to the alternate approach

Implemented

src/services/errorManagement/normalizeErrorMessage.ts

Add utility to normalize error messages by extracting dynamic values (UUIDs, IDs, hashes, etc.) and replacing them with placeholders. This enables better error grouping in monitoring tools.

morgan-wowk marked this pull request as ready for review January 26, 2026 21:12

morgan-wowk requested a review from a team as a code owner January 26, 2026 21:12

morgan-wowk requested review from Mbeaulne, camielvs and maxy-shpfy and removed request for a team January 26, 2026 21:12

Mbeaulne reviewed Jan 26, 2026

View reviewed changes

graphite-app bot reviewed Jan 26, 2026

View reviewed changes

src/services/errorManagement/normalizeErrorMessage.ts Outdated Show resolved Hide resolved

src/services/errorManagement/normalizeErrorMessage.ts Outdated Show resolved Hide resolved

morgan-wowk force-pushed the 01-26-chore_install_bugsnag_packages branch from eae3b11 to 8bd6752 Compare January 28, 2026 21:27

feat: add error message normalization utility

d7fc62b

Add utility to normalize error messages by extracting dynamic values (UUIDs, IDs, hashes, etc.) and replacing them with placeholders. This enables better error grouping in monitoring tools.

morgan-wowk changed the base branch from 01-26-chore_install_bugsnag_packages to graphite-base/1694 January 28, 2026 21:58

morgan-wowk force-pushed the graphite-base/1694 branch from 8bd6752 to 1a7c437 Compare January 28, 2026 21:58

morgan-wowk changed the base branch from graphite-base/1694 to master January 28, 2026 21:58

morgan-wowk closed this Jan 28, 2026

feat: add error message normalization utility #1694

feat: add error message normalization utility #1694

Uh oh!

Conversation

morgan-wowk commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

Checklist

Test Instructions

Uh oh!

morgan-wowk commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

morgan-wowk Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

morgan-wowk Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

morgan-wowk commented Jan 26, 2026 •

edited

Loading

morgan-wowk commented Jan 26, 2026 •

edited

Loading

morgan-wowk Jan 26, 2026 •

edited

Loading

morgan-wowk Jan 28, 2026 •

edited

Loading