feat: add unified ErrorHandler component #1697
Closed
+65
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 26, 2026
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jan 26, 2026
morgan-wowk
force-pushed
the
01-26-refactor-error-component-names
branch
from
5002cbc to
dc253c8
Compare
morgan-wowk
force-pushed
the
01-26-feat_add_unified_errorhandler_component_add_errorhandler_to_unify_error_handling_logic_for_both_react_error_boundaries_and_router_errors._automatically_reports_errors_to_bugsnag_and_provides_consistent_error_display_with_retry_g
branch
from
0fa7ae0 to
b8f873e
Compare
morgan-wowk
force-pushed
the
01-26-refactor-error-component-names
branch
from
dc253c8 to
9be3ab2
Compare
morgan-wowk
force-pushed
the
01-26-feat_add_unified_errorhandler_component_add_errorhandler_to_unify_error_handling_logic_for_both_react_error_boundaries_and_router_errors._automatically_reports_errors_to_bugsnag_and_provides_consistent_error_display_with_retry_g
branch
from
b8f873e to
2f5f3a3
Compare
morgan-wowk
force-pushed
the
01-26-refactor-error-component-names
branch
from
9be3ab2 to
d2ad4cd
Compare
morgan-wowk
force-pushed
the
01-26-feat_add_unified_errorhandler_component_add_errorhandler_to_unify_error_handling_logic_for_both_react_error_boundaries_and_router_errors._automatically_reports_errors_to_bugsnag_and_provides_consistent_error_display_with_retry_g
branch
from
2f5f3a3 to
bedeb6d
Compare
Mbeaulne
reviewed
Jan 26, 2026
|
|
||
| const handleRefresh = () => { | ||
| // Reset error boundary if available before reloading | ||
| resetErrorBoundary?.(); |
Collaborator
There was a problem hiding this comment.
What is this used for? seems like its only used in this file. lets remove it if we don't need it.
Mbeaulne
reviewed
Jan 26, 2026
Comment on lines
+48
to
+52
| if (onGoHome) { | ||
| onGoHome(); | ||
| } else { | ||
| window.location.href = "/"; | ||
| } |
Collaborator
There was a problem hiding this comment.
I wonder if we can just default onGoHome to be
onGoHome = () => window.location.href = "/";NIT: Do we rename this to something else? onGoToSafeURL or something
Mbeaulne
reviewed
Jan 26, 2026
|
|
||
| if (config.enabled && error instanceof Error) { | ||
| Bugsnag.notify(error, (event) => { | ||
| event.addMetadata("error_handler", { |
Collaborator
There was a problem hiding this comment.
Do we remove this magic string?
morgan-wowk
force-pushed
the
01-26-feat_add_unified_errorhandler_component_add_errorhandler_to_unify_error_handling_logic_for_both_react_error_boundaries_and_router_errors._automatically_reports_errors_to_bugsnag_and_provides_consistent_error_display_with_retry_g
branch
from
bedeb6d to
2b4b0cd
Compare
morgan-wowk
force-pushed
the
01-26-refactor-error-component-names
branch
from
d2ad4cd to
bedad4c
Compare
morgan-wowk
force-pushed
the
01-26-feat_add_unified_errorhandler_component_add_errorhandler_to_unify_error_handling_logic_for_both_react_error_boundaries_and_router_errors._automatically_reports_errors_to_bugsnag_and_provides_consistent_error_display_with_retry_g
branch
from
2b4b0cd to
7e226d9
Compare
morgan-wowk
force-pushed
the
01-26-refactor-error-component-names
branch
from
bedad4c to
43e186c
Compare
Add ErrorHandler to unify error handling logic for both React Error Boundaries and Router errors. Automatically reports errors to Bugsnag and provides consistent error display with retry/go-home actions.
morgan-wowk
force-pushed
the
01-26-refactor-error-component-names
branch
from
43e186c to
a8636d6
Compare
morgan-wowk
force-pushed
the
01-26-feat_add_unified_errorhandler_component_add_errorhandler_to_unify_error_handling_logic_for_both_react_error_boundaries_and_router_errors._automatically_reports_errors_to_bugsnag_and_provides_consistent_error_display_with_retry_g
branch
from
7e226d9 to
9322f42
Compare
Author
|
Note: I am actively working on implementing a refactor to simplify the contents of this PR |
morgan-wowk
changed the base branch from
01-26-refactor-error-component-names
to
graphite-base/1697
Author
|
This branch is not needed and closed. |
This was referenced Jan 28, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a unified
ErrorHandlercomponent to standardize error handling across the application. This component automatically reports errors to Bugsnag and provides consistent error display functionality for both React Error Boundaries and Router errors.The new component:
Updated
FullPageErrorto use the newErrorHandlercomponent instead of directly usingErrorDisplay.Type of Change
Checklist
Test Instructions