Skip to content

Fix and Expand Oni Demon Tail Markings#175

Open
rebaserHEAD wants to merge 1 commit into
Triad-Sector:mainfrom
rebaserHEAD:fix/oni-demon-tails
Open

Fix and Expand Oni Demon Tail Markings#175
rebaserHEAD wants to merge 1 commit into
Triad-Sector:mainfrom
rebaserHEAD:fix/oni-demon-tails

Conversation

@rebaserHEAD

Copy link
Copy Markdown
Collaborator

About the PR

Fixes the Demon Tail markings on Oni, which were rendering as broken fragments, and rounds the set out with the animated and plain variants from the original ADT source.

Why / Balance

The "ADT Markings (#49)" import brought these demon tails over as a single sprite layer, but in the ADT source each tail is two layers: a base silhouette (parts.rsi:tail) under a pattern/recolor overlay (tails_of_demons.rsi). Only the overlay was imported, so in-game there was no tail underneath the pattern and players saw scattered detail pixels. We re-sourced the base silhouette and the animated sheets from AdventureTimeSS14 (lunalita, CC-BY-SA-3.0, same as the rest of the sheet), added them to custom.rsi, and rewired the markings to layer base + overlay the way ADT intended. Purely cosmetic customization, no balance impact.

Media

image

Requirements

  • I have read relevant guidelines/documentation to this PR found on our devwiki.
  • I have added media to this PR or it does not require an ingame showcase.
  • I can confirm this PR contains either no AI-generated content, or AI-generated content that meets our guidelines.

How to test

  1. Open the character editor on an Oni.
  2. In the Tail marking slot, select Demon Tail 1 / Long / Up and confirm each renders a full, coherent tail (previously broken).
  3. Select the (Animated) variants and confirm the tail wags through its cycle, with the pattern staying aligned to the silhouette.
  4. Select the Plain and Plain (Animated) variants and confirm a single-color tail with no pattern overlay.
  5. Spot-check all four facings, and that the patterned tails expose two color layers (Tail + Pattern).

Breaking changes

None. The existing marking ids are unchanged, so saved characters keep their selections.

The ADT marking import brought these tails over as a single sprite layer, but each tail is two layers in the source: a base silhouette under a pattern overlay. Only the overlay was imported, so they rendered as broken fragments. Re-source the base silhouette and the animated sheets from AdventureTimeSS14, register them in custom.rsi, and layer base + overlay on DemomTail1/Long/Up. Also add the animated (waggin) and plain single-color tail variants.
@github-actions github-actions Bot added S: Untriaged size/M YML No C# Doesn't contain any C# code Sprites FTL Changes to localization files and removed S: Untriaged size/M labels Jun 1, 2026
@Triad-Sector Triad-Sector changed the title Fix and expand Oni demon tail markings Fix and Expand Oni Demon Tail Markings Jun 1, 2026
@github-actions

github-actions Bot commented Jun 1, 2026

Copy link
Copy Markdown

RSI Diff Bot; head commit 074d64c merging into ac55186
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/_ADT/Mobs/Customization/Demon/custom.rsi

State Old New Status
demon_tail_base Added
demon_tail_waggin Added
long_waggin Added
tail_waggin Added
up_waggin Added

@chadosmen1

Copy link
Copy Markdown

hello lead spriter here I am going to be reviewing this sprite to see if its fit to be added

@rebaserHEAD

Copy link
Copy Markdown
Collaborator Author

hello lead spriter here I am going to be reviewing this sprite to see if its fit to be added

What are we thinking, boss?

@DDrakov DDrakov left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and good enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

FTL Changes to localization files No C# Doesn't contain any C# code Sprites YML

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants