Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

@DaanHoogland DaanHoogland commented Sep 23, 2024

Description

This PR prevents a null display name on VMs (see #8503 (comment))

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.00%. Comparing base (b394b5b) to head (828f186).

❗ There is a different number of reports uploaded between BASE (b394b5b) and HEAD (828f186). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (b394b5b) HEAD (828f186)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##               4.20   #9719       +/-   ##
============================================
- Coverage     16.23%   4.00%   -12.24%     
============================================
  Files          5657     402     -5255     
  Lines        498865   32686   -466179     
  Branches      60545    5817    -54728     
============================================
- Hits          80991    1309    -79682     
+ Misses       408843   31222   -377621     
+ Partials       9031     155     -8876     
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11176

@weizhouapache
Copy link
Member

@DaanHoogland
it looks like an UI issue

the API response does have the "displayname" in place. but the name/displayname is not displayed on UI.

as a simple workaround, can we revert #8503 ? @DaanHoogland

@DaanHoogland
Copy link
Contributor Author

as a simple workaround, can we revert #8503 ? @DaanHoogland

yes, you are right, I'll creat another PR, reapply the changes here, and work on this later.

@weizhouapache
Copy link
Member

@blueorangutan ui

@blueorangutan
Copy link

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9719 (QA-JID-456)

@sureshanaparti sureshanaparti changed the title set desplayName to name by default set displayName to name by default Jun 5, 2025
@DaanHoogland DaanHoogland changed the base branch from 4.18 to 4.20 December 8, 2025 15:21
},
columns: () => {
const fields = ['name', 'state', 'ipaddress']
const fields = ['displayname', 'state', 'ipaddress']
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const fields = ['displayname', 'state', 'ipaddress']
const fields = ['name', 'state', 'ipaddress']

return fields
},
searchFilters: ['name', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'],
searchFilters: ['displayname', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
searchFilters: ['displayname', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'],
searchFilters: ['name', 'zoneid', 'domainid', 'account', 'groupid', 'arch', 'tags'],

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants