Skip to content

set displayName to name by default #9719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
DaanHoogland wants to merge 5 commits into
base: 4.20
Choose a base branch
from
+10 −1
Draft

set displayName to name by default #9719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b4ac303
set `desplayName` to `name` by default
DaanHoogland Sep 23, 2024
7e3bf26
list by displayname instead of name
DaanHoogland Jan 12, 2024
96988ea
Merge branch '4.20' into defaultDisplayName
DaanHoogland Dec 8, 2025
4da0dd2
Merge branch '4.20' into defaultDisplayName
DaanHoogland Dec 23, 2025
828f186
back to using name
Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion api/src/main/java/org/apache/cloudstack/api/command/user/vm/DeployVMCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,8 @@
import org.apache.commons.collections.CollectionUtils;
import org.apache.commons.collections.MapUtils;
import org.apache.commons.lang3.BooleanUtils;
import org.apache.commons.lang3.StringUtils;

import org.apache.log4j.Logger;

import com.cloud.agent.api.LogLevel;
import com.cloud.event.EventTypes;
Expand All @@ -74,6 +75,7 @@
import com.cloud.uservm.UserVm;
import com.cloud.utils.net.Dhcp;
import com.cloud.utils.net.NetUtils;
import com.cloud.utils.StringUtils;
import com.cloud.vm.VirtualMachine;
import com.cloud.vm.VmDetailConstants;

Expand Down Expand Up @@ -298,6 +300,9 @@ public String getDeploymentPlanner() {
}

public String getDisplayName() {
if (StringUtils.isEmpty(displayName)) {
displayName = name;
}
return displayName;
}

Expand Down
4 changes: 4 additions & 0 deletions api/src/main/java/org/apache/cloudstack/api/command/user/vm/UpdateVMCmd.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import java.util.List;
import java.util.Map;

import com.cloud.utils.StringUtils;
import com.cloud.utils.exception.CloudRuntimeException;

import org.apache.cloudstack.api.ApiArgValidator;
Expand Down Expand Up @@ -159,6 +160,9 @@ public class UpdateVMCmd extends BaseCustomIdCmd implements SecurityGroupAction,
/////////////////////////////////////////////////////

public String getDisplayName() {
if (StringUtils.isBlank(displayName)) {
displayName = name;
}
return displayName;
}

Expand Down
Loading