Skip to content

bring back most of the recoverWith changes#2694

Closed
pjfanning wants to merge 3 commits intoapache:mainfrom
pjfanning:recover
Closed

bring back most of the recoverWith changes#2694
pjfanning wants to merge 3 commits intoapache:mainfrom
pjfanning:recover

Conversation

@pjfanning
Copy link
Member

@pjfanning pjfanning commented Feb 28, 2026

  • aimed at 2.0.0 only - it doesn't seem worth the risk with breaking stuff on 1.x
  • omits the failure handling that was added before as this seems to be what caused the http2 testing issues in pekko-http
  • I have tested this with pekko-http locally
  • see Revert recent changes to recoverWith #2674
  • the original changes were by @He-Pin - I have just removed some parts that seemed to be problematic

@He-Pin
Copy link
Member

He-Pin commented Feb 28, 2026

thanks ,I was planning looking at it tomorrow, I will.check it in detail.

The problem is we don't have a test to cover the edge cases...

@pjfanning
Copy link
Member Author

I'd prefer to add the changes back incrementally but any enhancement to the test cases is definitely a great start

@pjfanning
Copy link
Member Author

#2712 covers this

@pjfanning pjfanning closed this Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants