bring back most of the recoverWith changes#2694
Closed
pjfanning wants to merge 3 commits intoapache:mainfrom
Closed
bring back most of the recoverWith changes#2694pjfanning wants to merge 3 commits intoapache:mainfrom
pjfanning wants to merge 3 commits intoapache:mainfrom
Conversation
Member
|
thanks ,I was planning looking at it tomorrow, I will.check it in detail. The problem is we don't have a test to cover the edge cases... |
Member
Author
|
I'd prefer to add the changes back incrementally but any enhancement to the test cases is definitely a great start |
Member
Author
|
#2712 covers this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.