fix: Fix recoverWith with add missing attempt back.#2712
Merged
Conversation
He-Pin
commented
Mar 4, 2026
| case singleSource: SingleSource[T @unchecked] => emit(out, singleSource.elem, () => completeStage()) | ||
| case failed: FailedSource[T @unchecked] => onFailure(failed.failure) | ||
| case failed: FailedSource[T @unchecked] => | ||
| attempt += 1 |
pjfanning
approved these changes
Mar 4, 2026
Member
pjfanning
left a comment
pjfanning
left a comment
There was a problem hiding this comment.
lgtm
I tried this on my laptop with the pekko-http tests that broke before and they work with this version.
I would appreciate if we just keep this as 2.0.0 change because I don't want to take any more risks with the 1.x releases.
Member
Author
|
Yeah，let's just keep it in 2.0.0， thanks for the testing |
Member
Author
|
It was spring festival, sorry for the delay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
It was reverted and there is a bug in that code.
refs: #2620
refs: #2694