fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks

[Aitema-gmbh]

SUMMARY

Implements WCAG 2.1 criterion 3.2.3 (Consistent Navigation, Level AA).

• Add aria-label="Main navigation" to the primary header navigation (Menu.tsx)
• Add aria-label="Page navigation" to the page-level sub-navigation (SubMenu.tsx)
• Screen readers can now distinguish between navigation regions

TESTING INSTRUCTIONS

1. Open any page with a screen reader
2. Navigate by landmarks → "Main navigation" and "Page navigation" should be announced as distinct regions
3. Verify both labels are present on all pages

ADDITIONAL INFORMATION

• Changes UI
  Part of a series of 16 individual WCAG 2.1 accessibility PRs. See also fix(a11y): Accessibility improvements for WCAG 2.1 Level A compliance #38342.

[bito-code-review]

Code Review Agent Run #587846

Actionable Suggestions - 0

Additional Suggestions - 2

• superset-frontend/src/features/home/Menu.tsx - 1

  • Hardcoded aria-label not translatable · Line 337-337
    The aria-label uses a hardcoded string, but per project standards, all user-facing text should be translatable. Other aria-labels in the codebase use t() for internationalization.
• superset-frontend/src/features/home/SubMenu.tsx - 1

  • Missing translation for aria-label · Line 213-213
    The aria-label 'Page navigation' is a user-facing string for accessibility that should be wrapped with t() for internationalization, following rule [6516]. Other user-facing strings in this file, like tooltip titles, already use t().
    Code suggestion

     @@ -213,1 +213,1 @@
    -      <Row className="menu" role="navigation" aria-label="Page navigation">
    +      <Row className="menu" role="navigation" aria-label={t('Page navigation')}>

Review Details

• Files reviewed - 2 · Commit Range: a70373a..a70373a

  • superset-frontend/src/features/home/Menu.tsx
  • superset-frontend/src/features/home/SubMenu.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #8c37b6

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: a70373a..1360c8c

  • superset-frontend/src/features/home/Menu.tsx
  • superset-frontend/src/features/home/SubMenu.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

LGTM! Will merge if it passes CI.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.37%. Comparing base (5815665) to head (1360c8c).
⚠️ Report is 132 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #39244      +/-   ##
==========================================
- Coverage   64.37%   64.37%   -0.01%     
==========================================
  Files        2550     2550              
  Lines      132180   132180              
  Branches    30661    30661              
==========================================
- Hits        85096    85092       -4     
- Misses      45599    45603       +4     
  Partials     1485     1485              

Flag	Coverage Δ
javascript	65.90% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.