Skip to content

fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks #39244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rusackas merged 2 commits into from
Apr 21, 2026
Merged

fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks #39244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a70373a
fix(a11y): WCAG 3.2.3 — add aria-labels to navigation landmarks for c…
Apr 9, 2026
1360c8c
fix(a11y): wrap aria-labels with t() for i18n support
Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion superset-frontend/src/features/home/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
*/
import { useState, useEffect } from 'react';
import { styled, css, useTheme } from '@apache-superset/core/theme';
import { t } from '@apache-superset/core/translation';
import { ensureStaticPrefix } from 'src/utils/assetUrl';
import { ensureAppRoot } from 'src/utils/pathUtils';
import { getUrlParam } from 'src/utils/urlUtils';
Expand Down Expand Up @@ -334,7 +335,7 @@ export function Menu({
return <>{link}</>;
};
return (
<StyledHeader className="top" id="main-menu" role="navigation">
<StyledHeader className="top" id="main-menu" role="navigation" aria-label={t('Main navigation')}>
<StyledRow>
<StyledCol md={16} xs={24}>
<Tooltip
Expand Down
2 changes: 1 addition & 1 deletion superset-frontend/src/features/home/SubMenu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,7 @@ const SubMenuComponent: FunctionComponent<SubMenuProps> = props => {

return (
<StyledHeader backgroundColor={props.backgroundColor}>
<Row className="menu" role="navigation">
<Row className="menu" role="navigation" aria-label={t('Page navigation')}>
{props.name && <div className="header">{props.name}</div>}
<Menu
mode={showMenu}
Expand Down
Loading