Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
We decided to hold this until the Proxy work has been completed so I'm going to move to a draft for now. |
Related-to: GH-704. Related-to: ENG-127.
wooorm-arcjet
force-pushed
the
wooorm/client-ip
branch
from
41cb255 to
d16f513
Compare
Related-to: GH-704. Related-to: ENG-127.
Related-to: GH-704. Related-to: ENG-127.
This is based on current workings, with additions of how it *could* work, marked with visible TODOs, linking to issues in `arcjet/arcjet-js`. This introduces a new “Concepts” section. Some users want to get started, some want to see Arcjets features, but some come in with a problem around a particular “topic”. I hope to put stuff like “Environment variables”, “Request body”, “Fingerprints”, and such typically finicky stuff under here. I explicitly want these a bit higher that “Advanced”, to not dissuade folks. But that’s where I want to go and as this is the lonely first, open to have it somewhere else. (note: not draft because I explicitly want to hear thoughts) Closes GH-703.
wooorm-arcjet
force-pushed
the
wooorm/client-ip
branch
from
a2cc836 to
8f97caf
Compare
|
@qw-in I am trying to launch this again. |
|
I think this will be replaced by a feature similar to https://github.com/arcjet/arcjet-py?tab=readme-ov-file#overriding-automatic-ip-detection for now I do certainly think there are parts that are worth keeping though! I'll have a closer look |
|
The JS version is a lot smarter than https://redirect.github.com/arcjet/arcjet-py/blob/a5ec064dea2e1df22bc30c291fd2da594186e51b/src/arcjet/context.py#L231-L254 though. |
4 participants
This is based on current workings, with additions of how it could work, marked with visible TODOs, linking to issues in
arcjet/arcjet-js.This introduces a new “Concepts” section.
Some users want to get started, some want to see Arcjets features, but some come in with a problem around a particular “topic”. I hope to put stuff like “Environment variables”, “Request body”, “Fingerprints”, and such typically finicky stuff under here. I explicitly want these a bit higher that “Advanced”, to not dissuade folks.
But that’s where I want to go and as this is the lonely first, open to have it somewhere else.
(note: not draft because I explicitly want to hear thoughts)
Closes GH-703.